Skip to content

debugger: enable linter on internal/inspector/inspect_client - #38417

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:inspect_client-linter
May 3, 2021
Merged

debugger: enable linter on internal/inspector/inspect_client#38417
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:inspect_client-linter

Conversation

@aduh95

@aduh95aduh95 commented Apr 26, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@github-actionsgithub-actionsBot added inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Apr 26, 2021
@aduh95
aduh95 requested a review from TrottApril 28, 2021 14:10
@nodejs-github-bot

nodejs-github-bot commented Apr 28, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37790/

@nodejs-github-bot

nodejs-github-bot commented Apr 29, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37798/

@nodejs-github-bot

nodejs-github-bot commented Apr 29, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37806/

Trott
Trott approved these changes May 2, 2021
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@nodejs-github-bot

nodejs-github-bot commented May 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37870/

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 2, 2021
@aduh95
debugger: enable linter on internal/inspector/inspect_client
2c0fd32
PR-URL: nodejs#38417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95
aduh95force-pushed the inspect_client-linter branch from baf3192 to 2c0fd32CompareMay 3, 2021 11:57
@aduh95

aduh95 commented May 3, 2021

Copy link
Copy Markdown
ContributorAuthor

Landed in 2c0fd32

@aduh95
aduh95 merged commit 2c0fd32 into nodejs:masterMay 3, 2021
@aduh95
aduh95 deleted the inspect_client-linter branch May 3, 2021 11:58
targos pushed a commit that referenced this pull request May 3, 2021
@aduh95@targos
debugger: enable linter on internal/inspector/inspect_client
0e446d6
PR-URL: #38417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request May 3, 2021
Merged
@richardlaurichardlau mentioned this pull request Jul 19, 2021
Closed
@richardlau

richardlau commented Jul 19, 2021

Copy link
Copy Markdown
Member

Backport to v14.x PR: #39446

aduh95 added a commit to aduh95/node that referenced this pull request Jul 20, 2021
@aduh95
debugger: enable linter on internal/inspector/inspect_client
9b960d9
PR-URL: nodejs#38417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@aduh95@richardlau
debugger: enable linter on internal/inspector/inspect_client
752282a
PR-URL: #38417
Backport-PR-URL: #39446
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@aduh95@richardlau
debugger: enable linter on internal/inspector/inspect_client
e58f938
PR-URL: #38417
Backport-PR-URL: #39446
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@richardlaurichardlau mentioned this pull request Jul 22, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.inspectorIssues and PRs related to the V8 inspector protocolneeds-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95@nodejs-github-bot@richardlau@jasnell@Trott@targos