Skip to content

doc: mark querystring api as legacy - #38436

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:mark-querystring-legacy
Closed

doc: mark querystring api as legacy#38436
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:mark-querystring-legacy

Conversation

@jasnell

Copy link
Copy Markdown
Member

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #38231

Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: nodejs#38231
@github-actionsgithub-actionsBot added doc Issues and PRs related to the documentations. querystring Issues and PRs related to the built-in querystring module. labels Apr 27, 2021
@jasnelljasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 27, 2021
@jasnell

Copy link
Copy Markdown
MemberAuthor

Simple change that shouldn't need to wait the 48 hours to land. Fast-track? Please 👍🏻

panva pushed a commit that referenced this pull request Apr 29, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231
PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@panva

Copy link
Copy Markdown
Member

Landed in 32ade69

@panvapanva closed this Apr 29, 2021
@aduh95aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 29, 2021
targos pushed a commit that referenced this pull request Apr 29, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231
PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targostargos mentioned this pull request May 3, 2021
targos pushed a commit that referenced this pull request May 30, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231
PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jun 5, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231
PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jun 5, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231
PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targostargos mentioned this pull request Jun 6, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231
PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.querystringIssues and PRs related to the built-in querystring module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate the old querystring in favor of URLSearchParams?

6 participants

@jasnell@panva@addaleax@targos@richardlau@aduh95