Skip to content

doc: minor clarification to pathObject - #38437

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-clarify-pathobject
Closed

doc: minor clarification to pathObject#38437
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-clarify-pathobject

Conversation

@jasnell

@jasnelljasnell commented Apr 27, 2021

Copy link
Copy Markdown
Member

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #36582

@jasnell
doc: minor clarification to pathObject
ad2281b
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: nodejs#36582
@github-actionsgithub-actionsBot added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. labels Apr 27, 2021
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2021
@jasnell

jasnell commented Apr 27, 2021

Copy link
Copy Markdown
MemberAuthor

Simple change that shouldn't need to wait the 48 hours to land. Fast-track? Please 👍🏻

@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 27, 2021
@jasnell

jasnell commented Apr 27, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 5a0ed51

@jasnelljasnell closed this Apr 27, 2021
jasnell added a commit that referenced this pull request Apr 27, 2021
@jasnell
doc: minor clarification to pathObject
5a0ed51
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #36582
PR-URL: #38437
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 29, 2021
@jasnell@targos
doc: minor clarification to pathObject
4b19bea
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #36582
PR-URL: #38437
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targostargos mentioned this pull request May 3, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@jasnell@targos
doc: minor clarification to pathObject
5e8f433
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #36582
PR-URL: #38437
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jun 5, 2021
@jasnell@targos
doc: minor clarification to pathObject
33ddb98
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #36582
PR-URL: #38437
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jun 5, 2021
@jasnell@targos
doc: minor clarification to pathObject
3509b0a
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #36582
PR-URL: #38437
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targostargos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@jasnell@targos
doc: minor clarification to pathObject
cd54834
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #36582
PR-URL: #38437
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.pathIssues and PRs related to the path subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: Please explain what "pathObject" is

3 participants

@jasnell@addaleax@aduh95