Skip to content

doc: clarify that fs.Dir async iterator closes automatically - #38438

Closed
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:fs-clarify-dir-async-iterator-close
Closed

doc: clarify that fs.Dir async iterator closes automatically#38438
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:fs-clarify-dir-async-iterator-close

Conversation

@jasnell

@jasnelljasnell commented Apr 27, 2021

Copy link
Copy Markdown
Member

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #35148

@github-actionsgithub-actionsBot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Apr 27, 2021
@jasnelljasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 27, 2021
@jasnell

Copy link
Copy Markdown
MemberAuthor

Simple change that shouldn't need to wait the 48 hours to land. Fast-track? Please 👍🏻

@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 87aca07

@jasnelljasnell closed this Apr 27, 2021
jasnell added a commit that referenced this pull request Apr 27, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #35148
PR-URL: #38438
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 29, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #35148
PR-URL: #38438
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targostargos mentioned this pull request May 3, 2021
targos pushed a commit that referenced this pull request Sep 4, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #35148
PR-URL: #38438
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targostargos mentioned this pull request Sep 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: undocumented magic: async iterator over fs.Dir will call dir.close() on iteration end

4 participants

@jasnell@addaleax@aduh95@targos