Uh oh!
There was an error while loading. Please reload this page.
punycode: add pending deprecation - #38444
Closed
aduh95 wants to merge 3 commits into
Closed
Conversation
jasnell
approved these changes
Apr 27, 2021
jasnell
left a comment
Member
There was a problem hiding this comment.
So long as this remains as just a --pending-deprecation for a while, +1
This comment has been minimized.
This comment has been minimized.
aduh95
commented
Apr 27, 2021
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Apr 27, 2021
nodejs-github-bot
commented
Apr 27, 2021
Collaborator
targos
approved these changes
Apr 28, 2021
nodejs-github-bot
commented
Apr 28, 2021
Collaborator
lpinca
approved these changes
Apr 28, 2021
trivikr
approved these changes
Apr 30, 2021
jasnell pushed a commit
that referenced
this pull request
Apr 30, 2021
PR-URL: #38444 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell
commented
Apr 30, 2021
Member
Landed in 40ea8aa |
targos
commented
Jul 17, 2021
Member
Should we really consider new pending deprecations semver-major? |
aduh95
commented
Jul 17, 2021
ContributorAuthor
No strong feeling from my side, I added the label to be conservative, but I don't see a problem if this lands in the current release lines. |
targos
commented
Jul 19, 2021
Member
I turned it into a notable change. I suggest to land it only on v16.x |
targos pushed a commit
that referenced
this pull request
Jul 20, 2021
PR-URL: #38444 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs added a commit
that referenced
this pull request
Jul 26, 2021
Notable changes: build: * (SEMVER-MINOR) reset embedder string to "-node.0" (Michaël Zasso) #39470 deps: * (SEMVER-MINOR) restore minimum ICU version to 68 (Michaël Zasso) #39470 * (SEMVER-MINOR) make V8 9.2 abi-compatible with 9.0 (Michaël Zasso) #39470 * (SEMVER-MINOR) update V8 to 9.2.230.21 (Michaël Zasso) #39470 inspector: * mark as stable (Gireesh Punathil) #37748 perf_hooks: * (SEMVER-MINOR) web performance timeline compliance (legendecas) #39297 punycode: * add pending deprecation (Antoine du Hamel) #38444 repl: * (SEMVER-MINOR) enable --experimental-repl-await /w opt-out (hemanth.hm) #34733 PR-URL: TODO
Merged
BethGriggs pushed a commit
that referenced
this pull request
Jul 29, 2021
PR-URL: #38444 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs added a commit
that referenced
this pull request
Jul 29, 2021
This is a security release. Notable Changes: - CVE-2021-22930: Use after free on close http2 on stream canceling (High) [#39423](#39423) - (SEMVER-MINOR) deps: update V8 to 9.2.230.21 (Michaël Zasso) [#39470](#39470) - inspector: mark as stable (Gireesh Punathil) [#37748](#37748) - (SEMVER-MINOR) perf_hooks: web performance timeline compliance (legendecas) [#39297](#39297) - punycode: add pending deprecation (Antoine du Hamel) [#38444](#38444) - (SEMVER-MINOR) repl: enable --experimental-repl-await /w opt-out (hemanth.hm) [#34733](#34733) PR-URL: #39534
BethGriggs added a commit
that referenced
this pull request
Jul 29, 2021
This is a security release. Notable Changes: - CVE-2021-22930: Use after free on close http2 on stream canceling (High) [#39423](#39423) - (SEMVER-MINOR) deps: update V8 to 9.2.230.21 (Michaël Zasso) [#39470](#39470) - inspector: mark as stable (Gireesh Punathil) [#37748](#37748) - punycode: add pending deprecation (Antoine du Hamel) [#38444](#38444) - (SEMVER-MINOR) repl: enable --experimental-repl-await /w opt-out (hemanth.hm) [#34733](#34733) PR-URL: #39534
BethGriggs added a commit
that referenced
this pull request
Jul 29, 2021
This is a security release. Notable Changes: - CVE-2021-22930: Use after free on close http2 on stream canceling (High) [#39423](#39423) - (SEMVER-MINOR) deps: update V8 to 9.2.230.21 (Michaël Zasso) [#39470](#39470) - inspector: mark as stable (Gireesh Punathil) [#37748](#37748) - punycode: add pending deprecation (Antoine du Hamel) [#38444](#38444) - (SEMVER-MINOR) repl: enable --experimental-repl-await /w opt-out (hemanth.hm) [#34733](#34733) PR-URL: #39534
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revival of #35092: now that #35091 is in Node.js v16.x, this module is unused in the codebase. I think we should move forward with this deprecation.