deps: V8: cherry-pick fd75c97d3f56

[targos]

Fixes interpretation of the following:

null?.(...[],1)

In Node.js <= 16.0.0, it incorrectly throws a TypeError.

Original commit message:

[interpreter] Apply Reflect.apply transform in BytecodeGenerator
Calls with a spread expression in a non-final position get transformed
to calls to Reflect.apply. This transformation is currently done in
the parser, which does not compose well with other features (e.g.
direct eval checking, optional chaining).
Do this transform in the BytecodeGenerator instead.
Bug: v8:11573, v8:11558, v8:5690
Change-Id: I56c90a2036fe5b43e0897c57766f666bf72bc3a8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2765783
Auto-Submit: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73534}

Refs: v8/v8@fd75c97

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37778/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3962/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37781/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37782/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37794/

[targos]

ARM compilation fails systematically with 06:22:01 g++: fatal error: Killed signal terminated program cc1plus
Any ideas?

[richardlau]

It's running out of memory. I logged into the machine while a build for this PR was in progress and ran top and watched the free memory decrease. This is what it is within minutes after the g++: fatal error: Killed signal terminated program cc1plus error while the job is in the process of exiting:

Tasks: 920 total, 46 running, 873 sleeping, 0 stopped, 1 zombie
%Cpu(s): 13.3 us, 1.1 sy, 0.0 ni, 64.2 id, 21.4 wa, 0.0 hi, 0.0 si, 0.0 st
KiB Mem : 31255808 total, 575424 free, 28573120 used, 2107264 buff/cache

I saw the free value drop to something like 74360 before going back up.

I'm not sure why that would be the case for this PR (other runs for other PRs and the daily masters are passing). FWIW I even forced a run on the other centos7-arm64-gcc8 host, which failed in the same way:
https://ci.nodejs.org/job/node-test-commit-arm/nodes=centos7-arm64-gcc8/37274/

[richardlau]

FWIW, when idle, top shows:

Tasks: 781 total, 1 running, 778 sleeping, 0 stopped, 2 zombie
%Cpu(s): 0.0 us, 0.0 sy, 0.0 ni,100.0 id, 0.0 wa, 0.0 hi, 0.0 si, 0.0 st
KiB Mem : 31255808 total, 26824832 free, 2187136 used, 2243840 buff/cache

[targos]

Is GCC up to date ? (In case it's a compiler bug)

[richardlau]

The machines are running 8.3.1 from devtoolset-8. I'll check if there are any updates.

[richardlau]

No available updates for gcc (the only available updates are to Java and nettle).

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37858/

[targos]

FWIW I see this in the logs: make run-ci -j 50 Isn't a parallelism of 50 a bit much?

[richardlau]

FWIW I see this in the logs: make run-ci -j 50 Isn't a parallelism of 50 a bit much?

🤷 The machines each have 96 cores and 25G of memory. Our ansible scripts have them set up for 50 "jobs" -- it hasn't been an issue before.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37861/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37867/

[targos]

Landed in 69c57e9