Skip to content

test,readline: improve tab completion coverage - #38465

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:readline-tab-completion-test-coverage
May 2, 2021
Merged

test,readline: improve tab completion coverage#38465
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:readline-tab-completion-test-coverage

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

Blocked on #38464

@aduh95aduh95 added the blocked PRs that are blocked by other issues or PRs. label Apr 29, 2021
@github-actionsgithub-actionsBot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 29, 2021
@aduh95aduh95 added readline Issues and PRs related to the built-in readline module. needs-ci PRs that need a full CI run. and removed needs-ci PRs that need a full CI run. labels Apr 29, 2021
@aduh95
aduh95force-pushed the readline-tab-completion-test-coverage branch from b291d15 to 4e2ed40CompareMay 2, 2021 08:39
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels May 2, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95aduh95 added blocked PRs that are blocked by other issues or PRs. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 2, 2021
@aduh95
aduh95force-pushed the readline-tab-completion-test-coverage branch 2 times, most recently from b291d15 to b53eb32CompareMay 2, 2021 09:58
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels May 2, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

PR-URL: nodejs#38465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@aduh95
aduh95force-pushed the readline-tab-completion-test-coverage branch from b53eb32 to 68e6673CompareMay 2, 2021 13:05
@aduh95

Copy link
Copy Markdown
ContributorAuthor

Landed in 68e6673

@aduh95
aduh95 merged commit 68e6673 into nodejs:masterMay 2, 2021
@aduh95
aduh95 deleted the readline-tab-completion-test-coverage branch May 2, 2021 13:06
targos pushed a commit that referenced this pull request May 3, 2021
PR-URL: #38465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targostargos mentioned this pull request May 3, 2021
targos pushed a commit that referenced this pull request May 30, 2021
PR-URL: #38465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #38465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #38465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targostargos mentioned this pull request Jun 6, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #38465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.readlineIssues and PRs related to the built-in readline module.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@Trott@targos