Skip to content

async_hooks: merge resource_symbol with owner_symbol - #38468

Closed
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:async_hooks/merge-resource_symbol-with-owner_symbol
Closed

async_hooks: merge resource_symbol with owner_symbol#38468
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:async_hooks/merge-resource_symbol-with-owner_symbol

Conversation

@RaisinTen

@RaisinTenRaisinTen commented Apr 29, 2021

Copy link
Copy Markdown
Member

As per this TODO comment:

node/lib/internal/async_hooks.js

Lines 182 to 183 in 6ca785b

// TODO(addaleax): Merge this with owner_symbol and use it across all
// AsyncWrap instances.

@github-actionsgithub-actionsBot added async_hooks Issues and PRs related to the async hooks subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 29, 2021
@RaisinTen

RaisinTen commented Apr 29, 2021

Copy link
Copy Markdown
MemberAuthor

cc @addaleax

jasnell
jasnell approved these changes Apr 29, 2021
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but definitely want @addaleax's look as well

addaleax
addaleax approved these changes Apr 30, 2021
View reviewed changes
Comment threadlib/internal/async_hooks.js Outdated
Comment threadlib/internal/async_hooks.js Outdated
RaisinTen
RaisinTen commented Apr 30, 2021
View reviewed changes
Comment threadsrc/async_wrap.cc Outdated
RaisinTen
RaisinTen commented Apr 30, 2021
View reviewed changes
Comment threadsrc/async_wrap.cc Outdated
@RaisinTenRaisinTen added the wip Issues and PRs that are still a work in progress. label May 6, 2021
Qard
Qard reviewed May 10, 2021
View reviewed changes
Comment threadsrc/async_wrap.cc Outdated
@RaisinTen
async_hooks: merge resource_symbol with owner_symbol
8fa2b28
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen
RaisinTenforce-pushed the async_hooks/merge-resource_symbol-with-owner_symbol branch from aa99773 to 8fa2b28CompareJuly 26, 2021 06:31
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen

RaisinTen commented Jul 26, 2021

Copy link
Copy Markdown
MemberAuthor

CI is mostly green. Could this please have another review? cc @jasnell@addaleax@Trott@Qard

@RaisinTenRaisinTen removed the wip Issues and PRs that are still a work in progress. label Jul 26, 2021
addaleax
addaleax approved these changes Jul 26, 2021
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I know that the constructor name checks may seem a bit icky here, but I think in the big picture doing this is definitely worth it 👍

@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 26, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2021•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39278/ 💚

@RaisinTen

RaisinTen commented Jul 27, 2021

Copy link
Copy Markdown
MemberAuthor

cc @nodejs/async_hooks if anyone else would also like to take a look.

@jasnell

jasnell commented Jul 28, 2021

Copy link
Copy Markdown
Member

Landed in 7ca2f13

@jasnelljasnell closed this Jul 28, 2021
jasnell pushed a commit that referenced this pull request Jul 28, 2021
@RaisinTen@jasnell
async_hooks: merge resource_symbol with owner_symbol
7ca2f13
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
PR-URL: #38468
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@RaisinTen
RaisinTen deleted the async_hooks/merge-resource_symbol-with-owner_symbol branch July 31, 2021 04:54
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@RaisinTen@danielleadams
async_hooks: merge resource_symbol with owner_symbol
a80c989
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
PR-URL: #38468
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Aug 16, 2021
Merged
@orgadsorgads mentioned this pull request Nov 2, 2021
Closed
@orgads

orgads commented Nov 2, 2021

Copy link
Copy Markdown
Contributor

This breaks AsyncLocalStorage for TCP/TLS sockets. See #40693.

@QardQard mentioned this pull request Nov 6, 2021
Closed
This was referenced Jun 15, 2022
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@QardQardAwaiting requested review from Qard
@TrottTrottAwaiting requested review from Trott

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@RaisinTen@nodejs-github-bot@jasnell@orgads@Qard@Trott@addaleax@benjamingr@targos