Uh oh!
There was an error while loading. Please reload this page.
[v14.x backport] stream: fix multiple Writable.destroy() calls - #38473
Closed
ronag wants to merge 1 commit into
Closed
[v14.x backport] stream: fix multiple Writable.destroy() calls#38473ronag wants to merge 1 commit into
ronag wants to merge 1 commit into
Conversation
ronagforce-pushed
the
backport-38221-to-v14.x
branch
from
April 29, 2021 18:47
6531b98 to
a540afdCompareronagforce-pushed
the
backport-38221-to-v14.x
branch
from
April 29, 2021 18:49
a540afd to
33424e6Comparenodejs-github-bot
commented
Apr 29, 2021
Collaborator
ronagforce-pushed
the
backport-38221-to-v14.x
branch
from
April 29, 2021 18:51
33424e6 to
fa4b816CompareCalling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: nodejs#38189 PR-URL: nodejs#38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#38473
ronagforce-pushed
the
backport-38221-to-v14.x
branch
from
April 29, 2021 18:51
fa4b816 to
e516c0aComparenodejs-github-bot
commented
Apr 29, 2021
Collaborator
ronag
commented
Apr 29, 2021
MemberAuthor
Not sure if there really is anything to backport here... |
targos
commented
Apr 30, 2021
Member
What do you mean? Does it cherry-pick without conflicts? |
ronag
commented
Apr 30, 2021
MemberAuthor
I mean that the only thing to backport is the test. The bug the commit fixes doesn't exist on 14.x. |
targos
commented
Apr 30, 2021
Member
Ah, I see. I think the backport was requested because of the |
targos
commented
Apr 30, 2021
Member
Do you know which commit/PR introduced the bug? |
danielleadams
commented
May 3, 2021
Contributor
Ah yes, it had the tag and when I tried to backport it didn't land cleanly. If there's nothing to backport, I guess we can just land the test if it covers the previous bug? |
targos pushed a commit
that referenced
this pull request
May 30, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: #38189 PR-URL: #38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #38473
targos
commented
May 30, 2021
Member
Landed in 358ae8b |
targos pushed a commit
that referenced
this pull request
Jun 5, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: #38189 PR-URL: #38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #38473
targos pushed a commit
that referenced
this pull request
Jun 5, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: #38189 PR-URL: #38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #38473
targos pushed a commit
that referenced
this pull request
Jun 11, 2021
Calling Writable.destroy() multiple times in the same tick could cause an assertion error. Fixes: #38189 PR-URL: #38221 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #38473
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling Writable.destroy() multiple times in the same tick
could cause an assertion error.
Fixes: #38189
PR-URL: #38221
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Nitzan Uziely linkgoron@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com