Skip to content

build: remove dependency on distutils.spawn - #38600

Merged
richardlau merged 1 commit into
nodejs:masterfrom
richardlau:nodistutils
May 10, 2021
Merged

build: remove dependency on distutils.spawn#38600
richardlau merged 1 commit into
nodejs:masterfrom
richardlau:nodistutils

Conversation

@richardlau

@richardlaurichardlau commented May 8, 2021

Copy link
Copy Markdown
Member

Debian based packages of Python 3 do not include distutils.spawn and
require an additional apt package to be installed (python3-distutils).
Replace use of distutils.spawn with shutil.which, available in all
versions of Python currently allowed by our configure scripts.

For the configure script only, fall back to distutils.spawn to allow
friendlier error messages when run on older unsupported versions of
Python (e.g. 2.7).

configure.py also uses distutils.version -- this appears to be
available in Debian packaged Python 3 without installing
python3-distutils so has been left as-is.

Refs: #30189

@github-actionsgithub-actionsBot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. labels May 8, 2021
@richardlau

richardlau commented May 8, 2021

Copy link
Copy Markdown
MemberAuthor

cc @nodejs/python

@nodejs-github-bot

nodejs-github-bot commented May 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37979/

@nodejs-github-bot

nodejs-github-bot commented May 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37982/

cclauss
cclauss approved these changes May 8, 2021
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this.

@richardlaurichardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 8, 2021
@richardlau
build: remove dependency on distutils.spawn
16982b6
Debian based packages of Python 3 do not include `distutils.spawn` and
require an additional apt package to be installed (`python3-distutils`).
Replace use of `distutils.spawn` with `shutil.which`, available in all
versions of Python currently allowed by our configure scripts.
For the `configure` script only, fall back to `distutils.spawn` to allow
friendlier error messages when run on older unsupported versions of
Python (e.g. 2.7).
`configure.py` also uses `distutils.version` -- this appears to be
available in Debian packaged Python 3 without installing
`python3-distutils` so has been left as-is.
PR-URL: nodejs#38600
Refs: nodejs#30189
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau

richardlau commented May 10, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 16982b6.

@richardlau
richardlau merged commit 16982b6 into nodejs:masterMay 10, 2021
@richardlau
richardlau deleted the nodistutils branch May 10, 2021 14:38
moander pushed a commit to moander/node that referenced this pull request May 11, 2021
@richardlau@moander
build: remove dependency on distutils.spawn
69d0271
Debian based packages of Python 3 do not include `distutils.spawn` and
require an additional apt package to be installed (`python3-distutils`).
Replace use of `distutils.spawn` with `shutil.which`, available in all
versions of Python currently allowed by our configure scripts.
For the `configure` script only, fall back to `distutils.spawn` to allow
friendlier error messages when run on older unsupported versions of
Python (e.g. 2.7).
`configure.py` also uses `distutils.version` -- this appears to be
available in Debian packaged Python 3 without installing
`python3-distutils` so has been left as-is.
PR-URL: nodejs#38600
Refs: nodejs#30189
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos

targos commented May 11, 2021

Copy link
Copy Markdown
Member

This broke V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3984/nodes=benchmark-ubuntu1604-intel-64,v8test=v8test/console

18:23:00 File "./configure.py", line 17, in <module>
18:23:00 from shutil import which
18:23:00 ImportError: cannot import name which

@cclauss

cclauss commented May 11, 2021

Copy link
Copy Markdown
Contributor

https://docs.python.org/3/library/shutil.html#shutil.which has been around since Python 3.3

@targos

targos commented May 11, 2021

Copy link
Copy Markdown
Member

Yeah, but V8 build system doesn't support Python 3, so this job still has to use Python 2

@richardlaurichardlau mentioned this pull request May 11, 2021
Merged
@richardlau

richardlau commented May 11, 2021

Copy link
Copy Markdown
MemberAuthor

😞. #38632 implements the fallback to find_executable from distutils.spawn to get the V8 CI job working again.

@richardlau

richardlau commented May 11, 2021

Copy link
Copy Markdown
MemberAuthor

This should be landable on earlier releases as long as it is accompanied by #38632.

@cclauss

cclauss commented May 11, 2021

Copy link
Copy Markdown
Contributor

Yeah, but V8 build system doesn't support Python 3

Python 2 died 500 daze ago... Did they not get the memo?

targos pushed a commit that referenced this pull request May 17, 2021
@richardlau@targos
build: remove dependency on distutils.spawn
3bb12db
Debian based packages of Python 3 do not include `distutils.spawn` and
require an additional apt package to be installed (`python3-distutils`).
Replace use of `distutils.spawn` with `shutil.which`, available in all
versions of Python currently allowed by our configure scripts.
For the `configure` script only, fall back to `distutils.spawn` to allow
friendlier error messages when run on older unsupported versions of
Python (e.g. 2.7).
`configure.py` also uses `distutils.version` -- this appears to be
available in Debian packaged Python 3 without installing
`python3-distutils` so has been left as-is.
PR-URL: #38600
Refs: #30189
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request May 18, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@richardlau@targos
build: remove dependency on distutils.spawn
5ff7aee
Debian based packages of Python 3 do not include `distutils.spawn` and
require an additional apt package to be installed (`python3-distutils`).
Replace use of `distutils.spawn` with `shutil.which`, available in all
versions of Python currently allowed by our configure scripts.
For the `configure` script only, fall back to `distutils.spawn` to allow
friendlier error messages when run on older unsupported versions of
Python (e.g. 2.7).
`configure.py` also uses `distutils.version` -- this appears to be
available in Debian packaged Python 3 without installing
`python3-distutils` so has been left as-is.
PR-URL: #38600
Refs: #30189
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@richardlau@targos
build: remove dependency on distutils.spawn
0e1c34a
Debian based packages of Python 3 do not include `distutils.spawn` and
require an additional apt package to be installed (`python3-distutils`).
Replace use of `distutils.spawn` with `shutil.which`, available in all
versions of Python currently allowed by our configure scripts.
For the `configure` script only, fall back to `distutils.spawn` to allow
friendlier error messages when run on older unsupported versions of
Python (e.g. 2.7).
`configure.py` also uses `distutils.version` -- this appears to be
available in Debian packaged Python 3 without installing
`python3-distutils` so has been left as-is.
PR-URL: #38600
Refs: #30189
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@richardlau@targos
build: remove dependency on distutils.spawn
7f09f60
Debian based packages of Python 3 do not include `distutils.spawn` and
require an additional apt package to be installed (`python3-distutils`).
Replace use of `distutils.spawn` with `shutil.which`, available in all
versions of Python currently allowed by our configure scripts.
For the `configure` script only, fall back to `distutils.spawn` to allow
friendlier error messages when run on older unsupported versions of
Python (e.g. 2.7).
`configure.py` also uses `distutils.version` -- this appears to be
available in Debian packaged Python 3 without installing
`python3-distutils` so has been left as-is.
PR-URL: #38600
Refs: #30189
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@richardlau@targos
build: remove dependency on distutils.spawn
754aa38
Debian based packages of Python 3 do not include `distutils.spawn` and
require an additional apt package to be installed (`python3-distutils`).
Replace use of `distutils.spawn` with `shutil.which`, available in all
versions of Python currently allowed by our configure scripts.
For the `configure` script only, fall back to `distutils.spawn` to allow
friendlier error messages when run on older unsupported versions of
Python (e.g. 2.7).
`configure.py` also uses `distutils.version` -- this appears to be
available in Debian packaged Python 3 without installing
`python3-distutils` so has been left as-is.
PR-URL: #38600
Refs: #30189
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@cclausscclausscclauss approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@richardlau@nodejs-github-bot@targos@cclauss@jasnell@Trott@RaisinTen