Skip to content

test: simplify test-path-resolve.js - #38671

Closed
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200513-test-simplify
Closed

test: simplify test-path-resolve.js#38671
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200513-test-simplify

Conversation

@himself65

Copy link
Copy Markdown
Member

No description provided.

@github-actionsgithub-actionsBot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 13, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@himself65himself65 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 28, 2021
himself65 added a commit that referenced this pull request May 28, 2021
PR-URL: #38671
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@himself65

Copy link
Copy Markdown
MemberAuthor

Landed in 8b09629

danielleadams pushed a commit that referenced this pull request May 31, 2021
PR-URL: #38671
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 31, 2021
richardlau pushed a commit that referenced this pull request Jul 16, 2021
PR-URL: #38671
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
PR-URL: #38671
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
PR-URL: #38671
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlaurichardlau mentioned this pull request Jul 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@himself65@nodejs-github-bot@jasnell@Trott@cjihrig@juanarbol