Skip to content

lib: support fs_event_wrap in the snapshot and load more modules eagerly - #38737

Closed
joyeecheung wants to merge 3 commits into
nodejs:masterfrom
joyeecheung:eager-load
Closed

lib: support fs_event_wrap in the snapshot and load more modules eagerly#38737
joyeecheung wants to merge 3 commits into
nodejs:masterfrom
joyeecheung:eager-load

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented May 19, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Now that we support more modules in the snapshot, it's no longer necessary to lazy load them for speeding up startup.

Refs: #35711

@joyeecheung
src: support fs_event_wrap binding in the snapshot
d4b4575
@joyeecheung
lib: load internal/fs/watchers and internal/fs/read_file_context early
c4f0832
So that they are included in the builtin snapshot
@joyeecheung
lib: remove unnecessary lazy loads
02df983
Now that more modules are included in the snapshot, it's not
necessary to lazy load them anymore
@github-actionsgithub-actionsBot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 19, 2021
@joyeecheungjoyeecheung changed the title lib: support fs_event_wrap in the snapshot and eagerly-load more moduleslib: support fs_event_wrap in the snapshot and load more modules eagerlyMay 19, 2021
@nodejs-github-bot

nodejs-github-bot commented May 19, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38213/

@nodejs-github-bot

nodejs-github-bot commented May 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38330/

joyeecheung added a commit that referenced this pull request May 27, 2021
@joyeecheung
src: support fs_event_wrap binding in the snapshot
39b0f4f
PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joyeecheung added a commit that referenced this pull request May 27, 2021
@joyeecheung
lib: load internal/fs/watchers and internal/fs/read_file_context early
9e42b4d
So that they are included in the builtin snapshot
PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joyeecheung added a commit that referenced this pull request May 27, 2021
@joyeecheung
lib: remove unnecessary lazy loads
a4ea9fc
Now that more modules are included in the snapshot, it's not
necessary to lazy load them anymore
PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@joyeecheung

joyeecheung commented May 27, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in b6471c9...a4ea9fc

danielleadams pushed a commit that referenced this pull request May 31, 2021
@joyeecheung@danielleadams
src: support fs_event_wrap binding in the snapshot
a1b0e64
PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request May 31, 2021
@joyeecheung@danielleadams
lib: load internal/fs/watchers and internal/fs/read_file_context early
5d9442a
So that they are included in the builtin snapshot
PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request May 31, 2021
@joyeecheung@danielleadams
lib: remove unnecessary lazy loads
7d3a8cb
Now that more modules are included in the snapshot, it's not
necessary to lazy load them anymore
PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadamsdanielleadams mentioned this pull request May 31, 2021
Merged
@richardlau

richardlau commented Jul 16, 2021

Copy link
Copy Markdown
Member

Blocked on #32984.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joyeecheung@nodejs-github-bot@richardlau@addaleax@VoltrexKeyva