Skip to content

tools: update ESLint to 7.27.0 - #38764

Closed
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:update/eslint
Closed

tools: update ESLint to 7.27.0#38764
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:update/eslint

Conversation

@lpinca

Copy link
Copy Markdown
Member

Update ESLint to 7.27.0

@github-actionsgithub-actionsBot added the tools Issues and PRs related to the tools directory. label May 22, 2021

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM assuming this was generated with the usual tools/updat-eslint.shscript. I certainly like the 44K lines removed.

@bl-ue

bl-ue commented May 25, 2021

Copy link
Copy Markdown
Contributor

Yeah, tasty crunch. 😋 Looks like they removed their lodash dependencies, that's why 🤔

eslint/eslint#14098 & eslint/eslint#14287 are the causes of this.

@kaizhu256

Copy link
Copy Markdown
Contributor

woot, lodash is a scourge that should be wiped from the planet.

lpinca added a commit that referenced this pull request May 26, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@lpinca

Copy link
Copy Markdown
MemberAuthor

Landed in b6471c9.

@lpincalpinca closed this May 26, 2021
@lpinca
lpinca deleted the update/eslint branch May 26, 2021 16:22
targos pushed a commit that referenced this pull request May 30, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request May 31, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 31, 2021
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Jun 6, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@lpinca@bl-ue@kaizhu256@Trott@cjihrig