Skip to content

docs: improved & fixed code sample - #38776

Closed
todortotev wants to merge 4 commits into
nodejs:masterfrom
todortotev:docs/better-code-sample
Closed

docs: improved & fixed code sample#38776
todortotev wants to merge 4 commits into
nodejs:masterfrom
todortotev:docs/better-code-sample

Conversation

@todortotev

Copy link
Copy Markdown
Contributor

Closes#38760

@github-actionsgithub-actionsBot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels May 22, 2021
Comment threaddoc/api/http.md Outdated
Comment threaddoc/api/http.md
todortotevand others added 2 commits May 23, 2021 09:46
Co-authored-by: Voltrex <62040526+VoltrexMaster@users.noreply.github.com>
@todortotev
todortotev requested a review from mscdexMay 24, 2021 09:34
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 24, 2021
@jasnell

Copy link
Copy Markdown
Member

Landed in 5a67f15

@jasnelljasnell closed this May 25, 2021
jasnell pushed a commit that referenced this pull request May 25, 2021
PR-URL: #38776
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request May 31, 2021
PR-URL: #38776
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 31, 2021
richardlau pushed a commit that referenced this pull request Jul 16, 2021
PR-URL: #38776
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
PR-URL: #38776
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
PR-URL: #38776
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@richardlaurichardlau mentioned this pull request Jul 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: (HTTP) http.request(url[, options][, callback]) sample code error

6 participants

@todortotev@jasnell@mscdex@aduh95@iamshouvikmitra@VoltrexKeyva