Skip to content

test: remove unnecessary --pending-deprecation flag - #38819

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:esm-exports-not-pending-deprecations
Jun 1, 2021
Merged

test: remove unnecessary --pending-deprecation flag#38819
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:esm-exports-not-pending-deprecations

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

Those have been migrated to runtime deprecation in v16.0.0.

@github-actionsgithub-actionsBot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 26, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 26, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

PR-URL: nodejs#38819
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
aduh95force-pushed the esm-exports-not-pending-deprecations branch from 7212173 to 26bf4f3CompareJune 1, 2021 22:17
@aduh95

Copy link
Copy Markdown
ContributorAuthor

Landed in 26bf4f3

@aduh95
aduh95 merged commit 26bf4f3 into nodejs:masterJun 1, 2021
@aduh95
aduh95 deleted the esm-exports-not-pending-deprecations branch June 1, 2021 22:17
danielleadams pushed a commit that referenced this pull request Jun 2, 2021
PR-URL: #38819
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jun 2, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@aduh95@nodejs-github-bot@jasnell@Trott@lpinca@RaisinTen@bl-ue@richardlau