Skip to content

fixed typo in documentation (n-api.md) - #38822

Closed
julianjany wants to merge 2 commits into
nodejs:masterfrom
julianjany:patch-1
Closed

fixed typo in documentation (n-api.md)#38822
julianjany wants to merge 2 commits into
nodejs:masterfrom
julianjany:patch-1

Conversation

@julianjany

@julianjanyjulianjany commented May 27, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

fixed typo in documentation (n-api.md):
Node-API -API

@github-actionsgithub-actionsBot added the doc Issues and PRs related to the documentations. label May 27, 2021
@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2021
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label May 27, 2021
@github-actions

github-actionsBot commented May 27, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Flarna

Flarna commented May 31, 2021

Copy link
Copy Markdown
Member

If I try to land this via git node land it tells Last GitHub CI failed which doesn't match to what I see here.

Any hint what's wrong here?

mhdawson
mhdawson approved these changes May 31, 2021
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejsnodejs deleted a comment from github-actionsBotMay 31, 2021
@Flarna

Flarna commented Jun 1, 2021

Copy link
Copy Markdown
Member

Landed in fc269b3

@FlarnaFlarna closed this Jun 1, 2021
Flarna pushed a commit that referenced this pull request Jun 1, 2021
@julianjany@Flarna
doc: fixed typo in n-api.md
fc269b3
PR-URL: #38822
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jun 1, 2021
@julianjany@danielleadams
doc: fixed typo in n-api.md
108ffdb
PR-URL: #38822
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadamsdanielleadams mentioned this pull request Jun 1, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@julianjany@richardlau
doc: fixed typo in n-api.md
8dcdddd
PR-URL: #38822
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@julianjany@richardlau
doc: fixed typo in n-api.md
1c164ba
PR-URL: #38822
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@julianjany@richardlau
doc: fixed typo in n-api.md
e36d2a6
PR-URL: #38822
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@richardlaurichardlau mentioned this pull request Jul 20, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes
@richardlaurichardlaurichardlau approved these changes
@marsonyamarsonyamarsonya approved these changes
@FlarnaFlarnaFlarna approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+2 more reviewers
@mhdawsonmhdawsonmhdawson approved these changes
@bl-uebl-uebl-ue approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@julianjany@Flarna@jasnell@Trott@lpinca@tniessen@richardlau@mhdawson@marsonya@RaisinTen@bl-ue