Skip to content

src: make InitializeOncePerProcess more flexible - #38888

Closed
codebytere wants to merge 1 commit into
nodejs:masterfrom
codebytere:wrap-v8-platform
Closed

src: make InitializeOncePerProcess more flexible#38888
codebytere wants to merge 1 commit into
nodejs:masterfrom
codebytere:wrap-v8-platform

Conversation

@codebytere

@codebyterecodebytere commented Jun 1, 2021•
edited
Loading

Copy link
Copy Markdown
Member

This PR adds customizability to InitializeOncePerProcess by adding an overload with a third parameter containing flags which specify which aspects of InitializeOncePerProcess to run.

@codebyterecodebytere added the embedding Issues and PRs related to embedding Node.js in another project. label Jun 1, 2021
@github-actionsgithub-actionsBot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 1, 2021
addaleax
addaleax requested changes Jun 1, 2021
View reviewed changes
Comment threadsrc/node.cc Outdated
@codebyterecodebytere changed the title src: add NODE_USE_V8_PLATFORM in InitializeOncePerProcesssrc: make InitializeOncePerProcess more flexibleJun 3, 2021
@codebyterecodebytere added the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 3, 2021
@codebytere
codebytere requested a review from addaleaxJune 3, 2021 10:46
@nodejs-github-bot

nodejs-github-bot commented Jun 3, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38472/

@codebyterecodebytere removed the needs-ci PRs that need a full CI run. label Jun 3, 2021
addaleax
addaleax approved these changes Jun 3, 2021
View reviewed changes
Comment threadsrc/node.cc Outdated
Comment threadsrc/node.h Outdated
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38489/

@codebytere

codebytere commented Jun 7, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Landed in d8d1d96

codebytere added a commit that referenced this pull request Jun 7, 2021
@codebytere
src: make InitializeOncePerProcess more flexible
d8d1d96
PR-URL: #38888
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere
codebytere deleted the wrap-v8-platform branch June 7, 2021 08:41
targos pushed a commit that referenced this pull request Jun 11, 2021
@codebytere@targos
src: make InitializeOncePerProcess more flexible
06afb8d
PR-URL: #38888
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jun 14, 2021
Merged
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2021
@codebytere
src: make InitializeOncePerProcess more flexible
59ba4a5
nodejs/node#38888
@codebyterecodebytere mentioned this pull request Jun 24, 2021
Closed
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2021
@codebytere
src: make InitializeOncePerProcess more flexible
1199163
nodejs/node#38888
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2021
@codebytere
src: make InitializeOncePerProcess more flexible
2bd8c68
nodejs/node#38888
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
+1 more reviewer
@bl-uebl-uebl-ue approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.embeddingIssues and PRs related to embedding Node.js in another project.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@codebytere@nodejs-github-bot@jasnell@addaleax@joyeecheung@bl-ue@targos