Uh oh!
There was an error while loading. Please reload this page.
tls: tweak clientCertEngine argument parsing - #38900
Closed
codebytere wants to merge 1 commit into
Closed
Conversation
codebytereforce-pushed
the
tweak-configSecureContext
branch
from
June 2, 2021 09:46
954ea8c to
37fb0b4Comparejasnell
approved these changes
Jun 2, 2021
bl-ue
approved these changes
Jun 2, 2021
nodejs-github-bot
commented
Jun 2, 2021
Collaborator
lpinca
approved these changes
Jun 2, 2021
Trott
approved these changes
Jun 2, 2021
nodejs-github-bot
commented
Jun 3, 2021
Collaborator
nodejs-github-bot
commented
Jun 4, 2021
Collaborator
codebytere added a commit
that referenced
this pull request
Jun 4, 2021
PR-URL: #38900 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
commented
Jun 4, 2021
MemberAuthor
Landed in dc25378 |
targos pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #38900 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
codebytere added a commit
to electron/electron
that referenced
this pull request
Jun 24, 2021
codebytere added a commit
to electron/electron
that referenced
this pull request
Jun 24, 2021
richardlau
commented
Jul 16, 2021
Member
This appears dependent on #38116 which is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR slightly tweaks the argument parsing within
configSecureContext.BoringSSL defines
OPENSSL_NO_ENGINEand jasnell@35274cb changed behavior so that if a badclientCertEngineargument is passed,ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED()will be thrown beforeERR_INVALID_ARG_TYPE.This made Electron's smoke test of
parallel/test-tls-clientcertengine-invalid-arg-type.jsfail - this PR makes that test pass once more for us.