Uh oh!
There was an error while loading. Please reload this page.
doc: deprecate type coercion for dns.lookup options - #38906
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
34fa6fa to
82ffb69Compare82ffb69 to
713319cCompareverbatim optiondns.lookup optionsaduh95
commented
Jun 11, 2021
@nodejs/tsc if #37931 lands, the type coercion on the Other For reference, here's the current logic: Lines 115 to 120 in fa1a842 |
| of the `PerformanceEntry` object. The existing accessors have been | ||
| deprecated and should no longer be used. | ||
| ### DEP0153: `dns.lookup` and `dnsPromises.lookup` options type coercion |
There was a problem hiding this comment.
I'm landing this now, but in general deprecation PRs should leave the code number unassigned (e.g. use DEP0XXX) so that the code can be assigned when it is landed.
jasnell
commented
Aug 17, 2021
Landed in fae352a...f41893e |
PR-URL: #38906 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #38906 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #38906 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #38906 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Notable changes: doc: * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) #38906 stream: * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) #39519 * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) #39628 util: * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) #39814 PR-URL: #39875
Notable changes: doc: * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) #38906 stream: * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) #39519 * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) #39628 util: * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) #39814 PR-URL: #39875
The plan is to replace this check:
node/lib/internal/dns/promises.js
Lines 115 to 117 in d8797f5
with a more robust
validateBooleancheck – and similar for otherdns.lookupoptions.