Skip to content

url: prevent pathname setter from erasing path of path-only URLs - #39060

Closed
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:url/pathname-setter-change
Closed

url: prevent pathname setter from erasing path of path-only URLs#39060
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:url/pathname-setter-change

Conversation

@RaisinTen

@RaisinTenRaisinTen commented Jun 17, 2021•
edited
Loading

Copy link
Copy Markdown
Member

This change prevents the pathname setter from erasing the path of
path-only URLs as that would make them cannot-be-a-base URLs.

The changes in all files except src/node_url.cc have been done by
running:

git node wpt url

Fixes: #39059
Signed-off-by: Darshan Sen darshan.sen@postman.com

@github-actionsgithub-actionsBot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jun 17, 2021
@RaisinTenRaisinTen mentioned this pull request Jun 17, 2021
Closed
aduh95
aduh95 reviewed Jun 17, 2021
View reviewed changes
Comment threadtest/fixtures/wpt/README.md Outdated
@RaisinTenRaisinTen added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@addaleax

addaleax commented Jun 17, 2021

Copy link
Copy Markdown
Member

Can you add a meaningful commit description or commit subject line?

@RaisinTen
RaisinTenforce-pushed the url/pathname-setter-change branch from cb5ac9d to 514e3fdCompareJune 18, 2021 13:29
@RaisinTenRaisinTen changed the title url: pathname setter changeurl: prevent pathname setter from erasing path of path-only URLsJun 18, 2021
@RaisinTen
RaisinTenforce-pushed the url/pathname-setter-change branch from 514e3fd to 841563eCompareJune 18, 2021 13:31
@RaisinTen

RaisinTen commented Jun 18, 2021

Copy link
Copy Markdown
MemberAuthor

@addaleax Updated. :) PTAL.

RaisinTen
RaisinTen commented Jun 18, 2021
View reviewed changes
Comment threadsrc/node_url.cc Outdated
@RaisinTenRaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 18, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTenRaisinTen added blocked PRs that are blocked by other issues or PRs. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 19, 2021
@RaisinTen

RaisinTen commented Jun 19, 2021

Copy link
Copy Markdown
MemberAuthor

Blocked till web-platform-tests/wpt#27720 lands.

@RaisinTen
RaisinTenforce-pushed the url/pathname-setter-change branch from 841563e to 143d369CompareJune 26, 2021 14:46
@RaisinTenRaisinTen added request-ci Add this label to start a Jenkins CI on a PR. and removed blocked PRs that are blocked by other issues or PRs. labels Jun 26, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen
url: prevent pathname setter from erasing path of path-only URLs
0a7e75d
This change prevents the pathname setter from erasing the path of
path-only URLs as that would make them cannot-be-a-base URLs.
The changes in all files except `src/node_url.cc` have been done by
running:
```console
git node wpt url
```
Fixes: nodejs#39059
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen
RaisinTenforce-pushed the url/pathname-setter-change branch from 9c2bed4 to 0a7e75dCompareJuly 10, 2021 13:39
@RaisinTenRaisinTen added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 10, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 10, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
RaisinTen
RaisinTen commented Jul 10, 2021
View reviewed changes
Comment threadsrc/node_url.cc
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2021•
edited by RaisinTen
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39097/ (⭐)

@RaisinTen

RaisinTen commented Jul 17, 2021

Copy link
Copy Markdown
MemberAuthor

Also, cc @nodejs/url

@RaisinTenRaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 18, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 18, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTenRaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 18, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 18, 2021
@github-actions

github-actionsBot commented Jul 18, 2021

Copy link
Copy Markdown
Contributor

Landed in fdf625b...00cac65

nodejs-github-bot pushed a commit that referenced this pull request Jul 18, 2021
@RaisinTen@nodejs-github-bot
url: prevent pathname setter from erasing path of path-only URLs
00cac65
This change prevents the pathname setter from erasing the path of
path-only URLs as that would make them cannot-be-a-base URLs.
The changes in all files except `src/node_url.cc` have been done by
running:
```console
git node wpt url
```
Fixes: #39059
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
PR-URL: #39060
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@RaisinTen
RaisinTen deleted the url/pathname-setter-change branch July 18, 2021 05:45
targos pushed a commit that referenced this pull request Jul 20, 2021
@RaisinTen@targos
url: prevent pathname setter from erasing path of path-only URLs
4b52a34
This change prevents the pathname setter from erasing the path of
path-only URLs as that would make them cannot-be-a-base URLs.
The changes in all files except `src/node_url.cc` have been done by
running:
```console
git node wpt url
```
Fixes: #39059
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
PR-URL: #39060
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Jul 26, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Jul 29, 2021
@RaisinTen@BethGriggs
url: prevent pathname setter from erasing path of path-only URLs
68fd6d5
This change prevents the pathname setter from erasing the path of
path-only URLs as that would make them cannot-be-a-base URLs.
The changes in all files except `src/node_url.cc` have been done by
running:
```console
git node wpt url
```
Fixes: #39059
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
PR-URL: #39060
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 left review comments
@addaleaxaddaleaxAwaiting requested review from addaleax
@jasnelljasnellAwaiting requested review from jasnell
@XadillaXXadillaXAwaiting requested review from XadillaX
+2 more reviewers
@TimothyGuTimothyGuTimothyGu approved these changes
@annevkannevkannevk left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

URL: pathname setter change

9 participants

@RaisinTen@nodejs-github-bot@addaleax@jasnell@TimothyGu@annevk@XadillaX@aduh95@targos