Skip to content

Fix building with external builtins #39090 - #39091

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
mmomtchev:nobuiltins-build
Jun 26, 2021
Merged

Fix building with external builtins #39090#39091
aduh95 merged 1 commit into
nodejs:masterfrom
mmomtchev:nobuiltins-build

Conversation

@mmomtchev

@mmomtchevmmomtchev commented Jun 19, 2021•
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

Fixes: #39090

@github-actionsgithub-actionsBot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 19, 2021
@addaleaxaddaleax added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jun 20, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2021
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38705/

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2021
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38707/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2021
@github-actionsgithub-actionsBot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 26, 2021
@github-actions

github-actionsBot commented Jun 26, 2021

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/39091
✔ Done loading data for nodejs/node/pull/39091
----------------------------------- PR info ------------------------------------
Title Fix building with external builtins #39090 (#39091)
Author Momtchil Momtchev (@mmomtchev)
Branch mmomtchev:nobuiltins-build -> nodejs:master
Labels author ready, c++
Commits 1
- Fix building with external builtins #39090
Committers 1
- Momtchil Momtchev PR-URL: https://github.com/nodejs/node/pull/39091
Fixes: https://github.com/nodejs/node/issues/39090
Reviewed-By: Anna Henningsen Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/39091
Fixes: https://github.com/nodejs/node/issues/39090
Reviewed-By: Anna Henningsen Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
ℹ This PR was created on Sat, 19 Jun 2021 14:53:26 GMT
✔ Approvals: 5
✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/39091#pullrequestreview-687920755
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/39091#pullrequestreview-687938982
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/39091#pullrequestreview-687944992
✔ - Darshan Sen (@RaisinTen): https://github.com/nodejs/node/pull/39091#pullrequestreview-688500108
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/39091#pullrequestreview-688798418
✔ Last GitHub Actions successful
ℹ Last Full PR CI on 2021-06-20T20:43:28Z: https://ci.nodejs.org/job/node-test-pull-request/38707/
- Querying data for job/node-test-pull-request/38707/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
* branch master -> FETCH_HEAD
✔ origin/master is now up-to-date
- Downloading patch for 39091
From https://github.com/nodejs/node
* branch refs/pull/39091/merge -> FETCH_HEAD
✔ Fetched commits as 520ad586584a..74b12e6d13de
--------------------------------------------------------------------------------
[master 2e821ef066] Fix building with external builtins #39090
Author: Momtchil Momtchev Date: Sat Jun 19 16:52:59 2021 +0200
1 file changed, 1 insertion(+)
✔ Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
Fix building with external builtins #39090

PR-URL: #39091

Fixes: #39090

Reviewed-By: Anna Henningsen anna@addaleax.net

Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

Reviewed-By: Colin Ihrig cjihrig@gmail.com

Reviewed-By: Darshan Sen raisinten@gmail.com

Reviewed-By: Luigi Pinca luigipinca@gmail.com
[master 3615ed5fe8] Fix building with external builtins #39090

Author: Momtchil Momtchev momtchil@momtchev.com

Date: Sat Jun 19 16:52:59 2021 +0200

1 file changed, 1 insertion(+)

✖ 3615ed5fe89bd151e5c48fb2a4444252efb70e8c

✔ 2:7 Valid fixes URL. fixes-url

✔ 0:0 blank line after title line-after-title

✔ 0:0 line-lengths are valid line-length

✔ 0:0 metadata is at end of message metadata-end

✔ 1:8 PR-URL is valid. pr-url

✔ 0:0 reviewers are valid reviewers

✖ 0:0 Missing subsystem. subsystem

✔ 0:0 Title is formatted correctly. title-format

✔ 0:0 Title is <= 50 columns. title-length
ℹ Please fix the commit message and try again.
https://github.com/nodejs/node/actions/runs/974315611

@mmomtchev@aduh95
build: fix building with external builtins
19b80cc
PR-URL: nodejs#39091Fixes: nodejs#39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95

aduh95 commented Jun 26, 2021

Copy link
Copy Markdown
Contributor

Landed in 19b80cc

@aduh95
aduh95 merged commit 19b80cc into nodejs:masterJun 26, 2021
targos pushed a commit that referenced this pull request Jul 11, 2021
@mmomtchev@targos
build: fix building with external builtins
65b56b3
PR-URL: #39091Fixes: #39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Jul 13, 2021
Merged
@aduh95aduh95 mentioned this pull request Jul 17, 2021
Closed
richardlau pushed a commit to RaisinTen/node that referenced this pull request Jul 19, 2021
@mmomtchev@richardlau
build: fix building with external builtins
86ab15d
PR-URL: nodejs#39091Fixes: nodejs#39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@mmomtchev@richardlau
build: fix building with external builtins
5f7c331
PR-URL: #39091
Backport-PR-URL: #39419Fixes: #39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@mmomtchev@richardlau
build: fix building with external builtins
1ab4f81
PR-URL: #39091
Backport-PR-URL: #39419Fixes: #39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlaurichardlau mentioned this pull request Jul 20, 2021
Merged
@targostargos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@aduh95aduh95aduh95 approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix the externally loaded builtins build

9 participants

@mmomtchev@nodejs-github-bot@aduh95@addaleax@lpinca@cjihrig@RaisinTen@targos@richardlau