Uh oh!
There was an error while loading. Please reload this page.
errors: remove eager stack generation for node errors - #39182
Merged
Conversation
guybedford
approved these changes
Jul 2, 2021
guybedford
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this, seems good to me. If anything the extended outputs on the cases that changed seem like an improvement as well.
nodejs-github-bot
commented
Jul 2, 2021
Collaborator
nodejs-github-bot
commented
Jul 2, 2021
Collaborator
nodejs-github-bot
commented
Jul 3, 2021
Collaborator
devsnek
commented
Jul 3, 2021
MemberAuthor
thanks for fixing this up guy. added ruben since this touches the repl tests. |
nodejs-github-bot
commented
Jul 3, 2021
Collaborator
guybedford
commented
Jul 5, 2021
Contributor
Strictly speaking this PR can land now. Did you still want to wait on a review from @BridgeAR further here Gus? |
devsnek
commented
Jul 5, 2021
MemberAuthor
🤷♂️ maybe give it a couple more days |
jasnell
approved these changes
Jul 8, 2021
PR-URL: nodejs#39182 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 11, 2021
PR-URL: #39182 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 18, 2026
This was referenced Jan 31, 2026
This was referenced Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves logic from
addCodeToNametoprepareStackTrace, which saves some upfront perf and also allows node errors to be overridden byoverrideStackTrace.cc @guybedford