Uh oh!
There was an error while loading. Please reload this page.
deps: patch V8 to 9.1.269.38 - #39196
Closed
targos wants to merge 1 commit into
Closed
Conversation
richardlau
approved these changes
Jun 29, 2021
gireeshpunathil
approved these changes
Jun 30, 2021
gengjiawen
approved these changes
Jun 30, 2021
nodejs-github-bot
commented
Jul 7, 2021
Collaborator
tniessen
approved these changes
Jul 7, 2021
cjihrig
approved these changes
Jul 8, 2021
nodejs-github-bot
commented
Jul 9, 2021
Collaborator
nodejs-github-bot
commented
Jul 10, 2021
Collaborator
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/39196 ✔ Done loading data for nodejs/node/pull/39196 ----------------------------------- PR info ------------------------------------ Title deps: patch V8 to 9.1.269.38 (#39196) Author Michaël Zasso (@targos) Branch targos:patch-v8-91 -> nodejs:master Labels author ready, backport-open-v14.x, dont-land-on-v12.x, needs-ci, v8 engine Commits 1 - deps: patch V8 to 9.1.269.38 Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/39196 Fixes: https://github.com/nodejs/node/issues/37553 Refs: https://github.com/v8/v8/compare/9.1.269.36...9.1.269.38 Reviewed-By: Richard Lau Reviewed-By: Gireesh Punathil Reviewed-By: Jiawen Geng Reviewed-By: Matteo Collina Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39196 Fixes: https://github.com/nodejs/node/issues/37553 Refs: https://github.com/v8/v8/compare/9.1.269.36...9.1.269.38 Reviewed-By: Richard Lau Reviewed-By: Gireesh Punathil Reviewed-By: Jiawen Geng Reviewed-By: Matteo Collina Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - deps: patch V8 to 9.1.269.38 ℹ This PR was created on Tue, 29 Jun 2021 18:42:34 GMT ✔ Approvals: 6 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/39196#pullrequestreview-695388471 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/39196#pullrequestreview-695638866 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/39196#pullrequestreview-695639089 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/39196#pullrequestreview-695711864 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/39196#pullrequestreview-701145607 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/39196#pullrequestreview-701545529 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-07-10T06:33:31Z: https://ci.nodejs.org/job/node-test-pull-request/38934/ ℹ Last V8 CI on 2021-07-09T11:58:35Z: https://ci.nodejs.org/job/node-test-commit-v8-linux/4127/ - Querying data for job/node-test-pull-request/38934/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1017514995 |
targos
commented
Jul 10, 2021
MemberAuthor
Landed in e2148d7 |
targos added a commit
that referenced
this pull request
Jul 10, 2021
Refs: v8/v8@9.1.269.36...9.1.269.38Fixes: #37553 PR-URL: #39196 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit
that referenced
this pull request
Jul 11, 2021
Refs: v8/v8@9.1.269.36...9.1.269.38Fixes: #37553 PR-URL: #39196 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@9.1.269.36...9.1.269.38
Fixes: #37553