Skip to content

doc: clarify module loading behavior - #3920

Closed
cjihrig wants to merge 0 commit into
nodejs:masterfrom
cjihrig:lookup-docs
Closed

doc: clarify module loading behavior#3920
cjihrig wants to merge 0 commit into
nodejs:masterfrom
cjihrig:lookup-docs

Conversation

@cjihrig

@cjihrigcjihrig commented Nov 19, 2015

Copy link
Copy Markdown
Contributor

The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873

@cjihrigcjihrig mentioned this pull request Nov 19, 2015
Closed
@jasnell

jasnell commented Nov 19, 2015

Copy link
Copy Markdown
Member

LGTM

@jasnelljasnell added doc Issues and PRs related to the documentations. lts-watch-v4.x labels Nov 19, 2015
@targos

targos commented Nov 19, 2015

Copy link
Copy Markdown
Member

LGTM

@mscdexmscdex added the module Issues and PRs related to the module subsystem. label Nov 19, 2015
cjihrig added a commit that referenced this pull request Nov 19, 2015
@cjihrig
doc: clarify module loading behavior
5900d14
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.
Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@cjihrigcjihrig closed this Nov 19, 2015
@cjihrig
cjihrig deleted the lookup-docs branch November 19, 2015 18:12
@Fishrock123Fishrock123 mentioned this pull request Nov 26, 2015
Closed
cjihrig added a commit that referenced this pull request Dec 1, 2015
@cjihrigMyles Borins
doc: clarify module loading behavior
ebf072a
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.
Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
cjihrig added a commit that referenced this pull request Dec 4, 2015
@cjihrig@rvagg
doc: clarify module loading behavior
13e8b84
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.
Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
cjihrig added a commit that referenced this pull request Dec 5, 2015
@cjihrig@rvagg
doc: clarify module loading behavior
bbcb2a2
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.
Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
This was referenced Dec 8, 2015
Closed
Merged
@jasnelljasnell mentioned this pull request Dec 17, 2015
Closed
cjihrig added a commit that referenced this pull request Dec 17, 2015
@cjihrig@jasnell
doc: clarify module loading behavior
4bc71e0
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.
Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
cjihrig added a commit that referenced this pull request Dec 23, 2015
@cjihrig@jasnell
doc: clarify module loading behavior
ad02f0e
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.
Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.moduleIssues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cjihrig@jasnell@targos@mscdex@MylesBorins