Skip to content

doc,tools: remove checkLinks.mjs - #39206

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:remove-checkLinks
Jul 23, 2021
Merged

doc,tools: remove checkLinks.mjs#39206
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:remove-checkLinks

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

The checks made by this are now integrated to remark-preset-lint-node, there are no reason to keep it around anymore.

Blocked on #39201 (first commit is from there).

@github-actionsgithub-actionsBot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jun 30, 2021
@aduh95aduh95 removed the needs-ci PRs that need a full CI run. label Jun 30, 2021
@aduh95aduh95 mentioned this pull request Jul 21, 2021
@aduh95aduh95 added the review wanted PRs that need reviews. label Jul 22, 2021
@aduh95
aduh95 requested a review from TrottJuly 22, 2021 22:12

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be rebased to get rid of the commit from #39201?

The checks made by this are now integrated to `remark-preset-lint-node`,
there are no reason to keep it around anymore.
PR-URL: nodejs#39206
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95
aduh95force-pushed the remove-checkLinks branch from 341489a to ab73d95CompareJuly 23, 2021 07:39
@aduh95

Copy link
Copy Markdown
ContributorAuthor

Landed in ab73d95

@aduh95
aduh95 merged commit ab73d95 into nodejs:masterJul 23, 2021
@aduh95
aduh95 deleted the remove-checkLinks branch July 23, 2021 07:39
targos pushed a commit that referenced this pull request Jul 25, 2021
The checks made by this are now integrated to `remark-preset-lint-node`,
there are no reason to keep it around anymore.
PR-URL: #39206
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Jul 26, 2021
BethGriggs pushed a commit that referenced this pull request Jul 29, 2021
The checks made by this are now integrated to `remark-preset-lint-node`,
there are no reason to keep it around anymore.
PR-URL: #39206
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
The checks made by this are now integrated to `remark-preset-lint-node`,
there are no reason to keep it around anymore.
PR-URL: #39206
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Sep 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.review wantedPRs that need reviews.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@aduh95@Trott