Skip to content

doc(async_hooks): fix imports in context example - #39229

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
yashLadha:fix_async_hooks_context_docs
Feb 3, 2022
Merged

doc(async_hooks): fix imports in context example#39229
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
yashLadha:fix_async_hooks_context_docs

Conversation

@yashLadha

Copy link
Copy Markdown
Contributor

Fixed imports of certain packages required to run the example.

@github-actionsgithub-actionsBot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Jul 2, 2021
@yashLadha
yashLadhaforce-pushed the fix_async_hooks_context_docs branch from e54ee54 to 5b91b6bCompareJuly 2, 2021 04:44

@RaisinTenRaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be doing this given #38382 (comment)? cc @aduh95

@RaisinTen
RaisinTen requested a review from aduh95July 10, 2021 14:24
Added imports for packages that is mentioned in the example of
async_hooks context example.
@Flarna
Flarnaforce-pushed the fix_async_hooks_context_docs branch from 5b91b6b to e8d2176CompareFebruary 3, 2022 10:38
@FlarnaFlarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 0f84217 into nodejs:masterFeb 3, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 0f84217

ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
Added imports for packages that is mentioned in the example of
async_hooks context example.
PR-URL: #39229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
Added imports for packages that is mentioned in the example of
async_hooks context example.
PR-URL: #39229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
Added imports for packages that is mentioned in the example of
async_hooks context example.
PR-URL: #39229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
Added imports for packages that is mentioned in the example of
async_hooks context example.
PR-URL: #39229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async_hooksIssues and PRs related to the async hooks subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@yashLadha@nodejs-github-bot@jasnell@targos@Flarna@RaisinTen