Uh oh!
There was an error while loading. Please reload this page.
Revert "stream: error Duplex write/read if not writable/readable" - #39246
Closed
targos wants to merge 1 commit into
Closed
Revert "stream: error Duplex write/read if not writable/readable"#39246targos wants to merge 1 commit into
targos wants to merge 1 commit into
Conversation
This reverts commit 954217a. It breaks npm.
targos
commented
Jul 3, 2021
MemberAuthor
To reproduce the issue before this commit: |
4 tasks
targos
commented
Jul 3, 2021
MemberAuthor
Here's the related code in npm that doesn't work as expected with the change: https://github.com/npm/gauge/blob/e1839fb2fddb15b6e468ff5ec90086c3c59e084d/index.js#L226-L232 It seems that either the |
ronag
commented
Jul 3, 2021
Member
I’ll take a look tonight |
ronag
commented
Jul 3, 2021
Member
@targos any possibility of a repro using just gauge? |
targos
commented
Jul 3, 2021
MemberAuthor
varGauge=require('./deps/npm/node_modules/gauge/index.js');vargauge=newGauge(process.stderr,{theme: {hasColor: true},template: [{type: 'progressbar',length: 20},{type: 'activityIndicator',kerning: 1,length: 1},{type: 'section',default: ''},':',{type: 'logline',kerning: 1,default: ''}]})gauge.show("working…",0)setTimeout(()=>{gauge.pulse();gauge.show("working…",0.25)},500)setTimeout(()=>{gauge.pulse();gauge.show("working…",0.50)},1000)setTimeout(()=>{gauge.pulse();gauge.show("working…",0.75)},1500)setTimeout(()=>{gauge.pulse();gauge.show("working…",0.99)},2000)setTimeout(()=>gauge.hide(),2300) |
Member
There is a redraw live loop bug in gauge… I’m not sure what change triggers it. It unnecessarily calls redraw in drain. I’ll try and see if I can workaround it without changing gauge. |
ronag added a commit
to nxtedition/node
that referenced
this pull request
Jul 3, 2021
HWM was set to 0 which would cause e.g. stdout.write(...) to always return false. Refs: nodejs#39246
Closed
ronag
requested changes
Jul 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 954217a.
It breaks npm.