Uh oh!
There was an error while loading. Please reload this page.
stream: fix performance regression - #39254
Closed
mscdex wants to merge 1 commit into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
mscdexforce-pushed
the
streams-fix-perf-regression
branch
from
July 4, 2021 11:20
3e5aa92 to
a1ee30bComparenodejs-github-bot
commented
Jul 4, 2021
Collaborator
ZYSzys
approved these changes
Jul 4, 2021
cjihrig
approved these changes
Jul 4, 2021
aduh95
approved these changes
Jul 4, 2021
lpinca
approved these changes
Jul 4, 2021
nodejs-github-bot
commented
Jul 7, 2021
Collaborator
jasnell
approved these changes
Jul 8, 2021
ronag
commented
Jul 8, 2021
Member
Landed in a5ba28d |
ronag pushed a commit
that referenced
this pull request
Jul 8, 2021
PR-URL: #39254 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark result: