Uh oh!
There was an error while loading. Please reload this page.
test: remove eslint-disable comment from fixture file - #39320
Merged
Conversation
himself65
approved these changes
Jul 9, 2021
nodejs-github-bot
commented
Jul 9, 2021
Collaborator
nodejs-github-bot
commented
Jul 9, 2021
Collaborator
targos
approved these changes
Jul 9, 2021
cjihrig
approved these changes
Jul 9, 2021
jasnell
approved these changes
Jul 9, 2021
RaisinTen
approved these changes
Jul 10, 2021
Fixtures are not linted so eslint-disable comments are unnecessary. PR-URL: nodejs#39320 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Trott
commented
Jul 11, 2021
MemberAuthor
Landed in 8970fa9 |
targos pushed a commit
that referenced
this pull request
Jul 11, 2021
Fixtures are not linted so eslint-disable comments are unnecessary. PR-URL: #39320 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 4, 2021
Fixtures are not linted so eslint-disable comments are unnecessary. PR-URL: #39320 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixtures are not linted so eslint-disable comments are unnecessary.