Skip to content

add to parent.children when module cached - #3933

Closed
welefen wants to merge 2 commits into
nodejs:masterfrom
welefen:master
Closed

add to parent.children when module cached#3933
welefen wants to merge 2 commits into
nodejs:masterfrom
welefen:master

Conversation

@welefen

Copy link
Copy Markdown

No description provided.

@targostargos added the module Issues and PRs related to the module subsystem. label Nov 20, 2015
@rvagg

Copy link
Copy Markdown
Member

Can you try and come up with a test for this @welefen? To both demonstrate the problem and prevent regressions. Also, if you do make jslint you'll probably find a couple of objections to your formatting.

@jasnell

Copy link
Copy Markdown
Member

also, @welefen , can I ask you to provide a description of the problem and fix being made in the commit log and PR text?

@welefen

Copy link
Copy Markdown
Author

i will do hot reload in Node.js with require.cache, when base file changed, it will be clear base file cache and which files required base file. but base file only be find in module.children which first required base file.

@jasnell

Copy link
Copy Markdown
Member

@welefen ... is this still something you want to pursue? If so, can you add some detail to the commit log per #3933 (comment) and possibly add a test case?

@Jokero

Copy link
Copy Markdown

@welefen ping

@jasnell

Copy link
Copy Markdown
Member

Closing given the lack of forward progress on this

@jasnelljasnell closed this Feb 28, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

moduleIssues and PRs related to the module subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@welefen@rvagg@jasnell@Jokero@targos