Uh oh!
There was an error while loading. Please reload this page.
test: put common lint exceptions into config file - #39358
Merged
Conversation
nodejs-github-bot
commented
Jul 11, 2021
Collaborator
This comment has been minimized.
This comment has been minimized.
targos
approved these changes
Jul 12, 2021
Collaborator
aduh95
approved these changes
Jul 12, 2021
Uh oh!
There was an error while loading. Please reload this page.
tniessen
approved these changes
Jul 12, 2021
tniessen
left a comment
Member
There was a problem hiding this comment.
LGTM apart from "no newline at end of file."
cjihrig
approved these changes
Jul 13, 2021
jasnell
approved these changes
Jul 13, 2021
lpinca
approved these changes
Jul 13, 2021
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Jul 14, 2021
Collaborator
For lint exceptions that are universal or near universal for `test/common`, put the exceptions in a config file rather than disabling the ESLint rules at the top of each file. PR-URL: nodejs#39358 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Jul 14, 2021
MemberAuthor
Landed in c506660 |
targos pushed a commit
that referenced
this pull request
Jul 17, 2021
For lint exceptions that are universal or near universal for `test/common`, put the exceptions in a config file rather than disabling the ESLint rules at the top of each file. PR-URL: #39358 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
Sep 4, 2021
For lint exceptions that are universal or near universal for `test/common`, put the exceptions in a config file rather than disabling the ESLint rules at the top of each file. PR-URL: #39358 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For lint exceptions that are universal or near universal for
test/common, put the exceptions in a config file rather than disablingthe ESLint rules at the top of each file.