Uh oh!
There was an error while loading. Please reload this page.
events: allow an event to be dispatched multiple times - #39395
Closed
lpinca wants to merge 1 commit into
Closed
Conversation
aduh95
reviewed
Jul 15, 2021
Uh oh!
There was an error while loading. Please reload this page.
Use a different flag to prevent recursive dispatching.
lpinca
commented
Jul 21, 2021
MemberAuthor
@aduh95 PTAL. |
aduh95
approved these changes
Jul 21, 2021
| // API completeness. | ||
| composedPath() { return this[kTarget] ? [this[kTarget]] : []; } | ||
| composedPath() { return this[kIsBeingDispatched] ? [this[kTarget]] : []; } |
Contributor
There was a problem hiding this comment.
Unrelated to this PR: Chromium and Safari both return an empty array when dispatching an event. Firefox has the same behavior as Node.js. I couldn't find which behavior is spec compliant.
{// Same event dispatched multiple times.constevent=newEvent('foo');consteventTarget1=newEventTarget();consteventTarget2=newEventTarget();eventTarget1.addEventListener('foo',((event)=>{console.log(event.target===eventTarget1,event.eventPhase===Event.AT_TARGET);// true trueconstpath=event.composedPath();console.log(path.length===1,path[0]===eventTarget1);// depends on the browser:// On Firefox + Node.js: true true// On Safari + Chromium : false false}));eventTarget2.addEventListener('foo',((event)=>{console.log(event.target===eventTarget2,event.eventPhase===Event.AT_TARGET);// true trueconstpath=event.composedPath();console.log(path.length===1,path[0]===eventTarget2);// depends on the browser}));eventTarget1.dispatchEvent(event);console.log(event.target===eventTarget1,event.eventPhase===Event.NONE);// true trueconsole.log(event.composedPath().length===0);// trueeventTarget2.dispatchEvent(event);console.log(event.target===eventTarget2,event.eventPhase===Event.NONE);// true trueconsole.log(event.composedPath().length===0);// true}nodejs-github-bot
commented
Jul 21, 2021
Collaborator
jasnell
approved these changes
Jul 21, 2021
nodejs-github-bot
commented
Jul 21, 2021
Collaborator
nodejs-github-bot
commented
Jul 25, 2021
Collaborator
lpinca added a commit
that referenced
this pull request
Jul 25, 2021
Use a different flag to prevent recursive dispatching. PR-URL: #39395 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
lpinca
commented
Jul 25, 2021
MemberAuthor
Landed in 5c4e673. |
targos pushed a commit
that referenced
this pull request
Jul 26, 2021
Use a different flag to prevent recursive dispatching. PR-URL: #39395 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Jul 29, 2021
Use a different flag to prevent recursive dispatching. PR-URL: #39395 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
mrbbot added a commit
to mrbbot/node
that referenced
this pull request
Aug 15, 2021
Fast path for EventTarget dispatch with no listeners didn't reset kIsBeingDispatched flag, meaning same event couldn't be dispatched multiple times. Refs: nodejs#39395
lpinca pushed a commit
that referenced
this pull request
Sep 26, 2021
Fast path for EventTarget dispatch with no listeners didn't reset kIsBeingDispatched flag, meaning same event couldn't be dispatched multiple times. PR-URL: #39772 Refs: #39395 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit
that referenced
this pull request
Oct 4, 2021
Fast path for EventTarget dispatch with no listeners didn't reset kIsBeingDispatched flag, meaning same event couldn't be dispatched multiple times. PR-URL: #39772 Refs: #39395 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a different flag to prevent recursive dispatching.