Uh oh!
There was an error while loading. Please reload this page.
tools: fix broken link hash - #39426
Closed
Trott wants to merge 1 commit into
Closed
Conversation
This typo results in a non-functional link in the WebCrypto docs. This change fixes it.
targos
approved these changes
Jul 18, 2021
lpinca
approved these changes
Jul 18, 2021
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Jul 18, 2021
Collaborator
Contributor
Fast-track has been requested by @Trott. Please 👍 to approve. |
Trott
commented
Jul 18, 2021
MemberAuthor
Fast-track request is so that this doesn't block #39429 |
tniessen
approved these changes
Jul 18, 2021
cjihrig
approved these changes
Jul 18, 2021
Contributor
Landed in a28e6bf...ffa79b3 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Jul 18, 2021
This typo results in a non-functional link in the WebCrypto docs. This change fixes it. PR-URL: #39426 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jul 19, 2021
The internal link checker was missing some broken links because it was being too restrictive about the characters it accepted as part of a link hash. Accept anything that isn't a terminating quotation mark. Refs: nodejs#39426 Refs: nodejs#39425
targos pushed a commit
that referenced
this pull request
Jul 20, 2021
This typo results in a non-functional link in the WebCrypto docs. This change fixes it. PR-URL: #39426 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs-github-bot pushed a commit
that referenced
this pull request
Jul 20, 2021
The internal link checker was missing some broken links because it was being too restrictive about the characters it accepted as part of a link hash. Accept anything that isn't a terminating quotation mark. Refs: #39426 Refs: #39425 PR-URL: #39429 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
targos pushed a commit
that referenced
this pull request
Jul 21, 2021
The internal link checker was missing some broken links because it was being too restrictive about the characters it accepted as part of a link hash. Accept anything that isn't a terminating quotation mark. Refs: #39426 Refs: #39425 PR-URL: #39429 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Jul 29, 2021
This typo results in a non-functional link in the WebCrypto docs. This change fixes it. PR-URL: #39426 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Jul 29, 2021
The internal link checker was missing some broken links because it was being too restrictive about the characters it accepted as part of a link hash. Accept anything that isn't a terminating quotation mark. Refs: #39426 Refs: #39425 PR-URL: #39429 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
targos pushed a commit
that referenced
this pull request
Sep 4, 2021
The internal link checker was missing some broken links because it was being too restrictive about the characters it accepted as part of a link hash. Accept anything that isn't a terminating quotation mark. Refs: #39426 Refs: #39425 PR-URL: #39429 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This typo results in a non-functional link in the WebCrypto docs. This
change fixes it.