Skip to content

meta: add .mailmap entry for new email for existing contributor - #39431

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:update-ds
Closed

meta: add .mailmap entry for new email for existing contributor#39431
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:update-ds

Conversation

@Trott

Copy link
Copy Markdown
Member

No description provided.

@Trott
Trott requested a review from RaisinTenJuly 18, 2021 23:46
@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 18, 2021
@Trott

Copy link
Copy Markdown
MemberAuthor

@RaisinTen Not sure if you want to map the new email to the old one, like I did here, or if you'd rather do it the other way around and have the old email address map to the new one?

@RaisinTenRaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 19, 2021
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 19, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@jasnell

Copy link
Copy Markdown
Member

Landed in d0b440c

@jasnelljasnell closed this Jul 19, 2021
jasnell pushed a commit that referenced this pull request Jul 19, 2021
PR-URL: #39431
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2021
PR-URL: #39431
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Jul 26, 2021
BethGriggs pushed a commit that referenced this pull request Jul 29, 2021
PR-URL: #39431
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
PR-URL: #39431
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Sep 4, 2021
@Trott
Trott deleted the update-ds branch September 25, 2022 17:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@jasnell@tniessen@RaisinTen@nodejs-github-bot