Skip to content

net: add localAddress/Port for better error msgs - #3946

Closed
jscissr wants to merge 4 commits into
nodejs:masterfrom
jscissr:patch-2
Closed

net: add localAddress/Port for better error msgs#3946
jscissr wants to merge 4 commits into
nodejs:masterfrom
jscissr:patch-2

Conversation

@jscissr

@jscissrjscissr commented Nov 20, 2015

Copy link
Copy Markdown
Contributor

That could result in an error being thrown while creating an error...

@mscdexmscdex added the net Issues and PRs related to the net subsystem. label Nov 20, 2015
@jasnell

jasnell commented Nov 20, 2015

Copy link
Copy Markdown
Member

how odd that this wasn't caught before. LGTM but it would be helpful to have a quick test case included that fails before this is fix but works after.

@evanlucas

evanlucas commented Nov 20, 2015

Copy link
Copy Markdown
Contributor

Yea, apologies on that...not sure how that was missed :/

LGTM

@jscissr

jscissr commented Nov 21, 2015

Copy link
Copy Markdown
ContributorAuthor

I'll try making a test

@jasnell

jasnell commented Nov 21, 2015

Copy link
Copy Markdown
Member

It's not critical, just helpful. :) thank you!
On Nov 20, 2015 4:50 PM, "Jan Schär" notifications@github.com wrote:

I'll try making a test

—
Reply to this email directly or view it on GitHub
#3946 (comment).

@jscissr

jscissr commented Nov 21, 2015

Copy link
Copy Markdown
ContributorAuthor

Hmm, it looks like req.localAddress and req.localPort isn't even set anywhere, so the if block will never execute...
Should I add them after https://github.com/jscissr/node/blob/patch-2/lib/net.js#L819 ?

At least it means the worst that can happen is that you don't get a nice error message in the onerror event.

@jscissr
net: add localAddress/Port for better error msgs
751f4f4
The code generating the errror messages was already there, but it could
never execute because these properties were not set.
jscissr
jscissr reviewed Nov 21, 2015
View reviewed changes
Comment threadtest/parallel/test-net-connect-local-error.js Outdated

@jscissrjscissrNov 21, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure which port to use here, it simply should produce an ECONNREFUSED error when connecting.

evanlucas
evanlucas reviewed Nov 23, 2015
View reviewed changes
Comment threadtest/parallel/test-net-connect-local-error.js Outdated

@evanlucasevanlucasNov 23, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind making these const instead of var?

@jscissrjscissrNov 23, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied that from another test. Should I make a PR that changes this for every test where it isn't already the new way?

@evanlucasevanlucasNov 23, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the plan is to update them as we go. But in general, all new tests should use const wherever possible

@cjihrig

cjihrig commented Nov 23, 2015

Copy link
Copy Markdown
Contributor

LGTM pending comments and CI

@jscissrjscissr changed the title net: variable ex used before definednet: add localAddress/Port for better error msgsNov 23, 2015
@evanlucas

evanlucas commented Nov 23, 2015

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/816/

LGTM if CI is happy

@jscissr

jscissr commented Nov 24, 2015

Copy link
Copy Markdown
ContributorAuthor

It looks like something was wrong with the CI server. Can you restart it @evanlucas?

@evanlucas

evanlucas commented Nov 24, 2015

Copy link
Copy Markdown
Contributor

Sure, https://ci.nodejs.org/job/node-test-pull-request/837/

evanlucas pushed a commit that referenced this pull request Nov 24, 2015
@jscissr@evanlucas
net: add local address/port for better errors
d7b199d
Adds localAddress and localPort to req so we have better error messages.
Also fixes a case where ex is used before it is declared.
PR-URL: #3946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@evanlucas

evanlucas commented Nov 24, 2015

Copy link
Copy Markdown
Contributor

Landed in d7b199d. I went ahead and squashed the commits into 1 also. Thanks!

@jscissr
jscissr deleted the patch-2 branch November 25, 2015 21:02
@Fishrock123Fishrock123 mentioned this pull request Nov 26, 2015
Closed
MylesBorins pushed a commit that referenced this pull request Dec 1, 2015
@jscissrMyles Borins
net: add local address/port for better errors
2577a30
Adds localAddress and localPort to req so we have better error messages.
Also fixes a case where ex is used before it is declared.
PR-URL: #3946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Dec 4, 2015
@jscissr@rvagg
net: add local address/port for better errors
02dcdcb
Adds localAddress and localPort to req so we have better error messages.
Also fixes a case where ex is used before it is declared.
PR-URL: #3946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Dec 5, 2015
@jscissr@rvagg
net: add local address/port for better errors
baac81d
Adds localAddress and localPort to req so we have better error messages.
Also fixes a case where ex is used before it is declared.
PR-URL: #3946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Dec 8, 2015
Closed
Merged
@jasnelljasnell mentioned this pull request Dec 17, 2015
Closed
jasnell pushed a commit that referenced this pull request Dec 17, 2015
@jscissr@jasnell
net: add local address/port for better errors
aa85d62
Adds localAddress and localPort to req so we have better error messages.
Also fixes a case where ex is used before it is declared.
PR-URL: #3946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit that referenced this pull request Dec 23, 2015
@jscissr@jasnell
net: add local address/port for better errors
f0e37c2
Adds localAddress and localPort to req so we have better error messages.
Also fixes a case where ex is used before it is declared.
PR-URL: #3946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

netIssues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jscissr@jasnell@evanlucas@cjihrig@mscdex@MylesBorins