Skip to content

module: refine enrichCJSError - #39507

Closed
aduh95 wants to merge 3 commits into
nodejs:masterfrom
aduh95:richer-ESM-in-CJS-warning
Closed

module: refine enrichCJSError#39507
aduh95 wants to merge 3 commits into
nodejs:masterfrom
aduh95:richer-ESM-in-CJS-warning

Conversation

@aduh95

@aduh95aduh95 commented Jul 24, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Using hasESMSyntax utility introduced in #39175.

/cc @nodejs/modules

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jul 24, 2021
guybedford
guybedford approved these changes Jul 24, 2021
View reviewed changes

@guybedfordguybedford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Comment threadlib/internal/modules/esm/translators.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Jul 24, 2021
View reviewed changes
Comment threadlib/internal/modules/esm/translators.js Outdated
@aduh95@VoltrexKeyva
fixup! module: refine enrichCJSError
449e198
Co-authored-by: Voltrex <mohammadkeyvanzade94@gmail.com>
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 24, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2021
@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39254/

@jasnell

jasnell commented Jul 26, 2021

Copy link
Copy Markdown
Member

Landed in da0ede1

@jasnelljasnell closed this Jul 26, 2021
jasnell pushed a commit that referenced this pull request Jul 26, 2021
@aduh95@jasnell
module: refine enrichCJSError
da0ede1
PR-URL: #39507
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
aduh95 deleted the richer-ESM-in-CJS-warning branch July 26, 2021 16:03
targos pushed a commit that referenced this pull request Aug 2, 2021
@aduh95@targos
module: refine enrichCJSError
e13162d
PR-URL: #39507
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Aug 2, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb left review comments
@jasnelljasnelljasnell approved these changes
@guybedfordguybedfordguybedford approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aduh95@nodejs-github-bot@jasnell@ljharb@guybedford@VoltrexKeyva@targos