Uh oh!
There was an error while loading. Please reload this page.
[v14.x-backport] report: generates report on threads with no isolates - #39515
Closed
legendecas wants to merge 2 commits into
Closed
[v14.x-backport] report: generates report on threads with no isolates#39515legendecas wants to merge 2 commits into
legendecas wants to merge 2 commits into
Conversation
legendecas
requested review from
cjihrig, gireeshpunathil and himself65
and removed request for
cjihrig and gireeshpunathilJuly 25, 2021 16:42
legendecasforce-pushed
the
backport-to-14/38994
branch
from
July 25, 2021 16:47
bfb6773 to
60b98e8Comparenodejs-github-bot
commented
Jul 25, 2021
Collaborator
nodejs-github-bot
commented
Jul 25, 2021
Collaborator
targos
commented
Aug 8, 2021
Member
Can you please rebase? |
targos
commented
Aug 29, 2021
Member
ping @legendecas |
legendecasforce-pushed
the
backport-to-14/38994
branch
from
August 30, 2021 16:08
60b98e8 to
550f5d9Comparelegendecas
commented
Aug 30, 2021
MemberAuthor
@targos updated! :) |
MylesBorinsforce-pushed
the
v14.x-staging
branch
from
August 31, 2021 14:58
b3f51ee to
327838dComparenapi_fatal_error and node watchdog trigger fatal error but rather running on a thread that hold no current isolate. PR-URL: nodejs#38624 Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#38994 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
targosforce-pushed
the
backport-to-14/38994
branch
from
September 1, 2021 17:33
550f5d9 to
3cab19cComparetargos
commented
Sep 3, 2021
Member
Landed in a74032a...f69c934 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backport contains following commits:
report: generates report on threads with no isolates
PR-URL: #38994
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
src: fix fatal errors when a current isolate not exist
napi_fatal_error and node watchdog trigger fatal error but rather
running on a thread that hold no current isolate.
PR-URL: #38624
Reviewed-By: Michael Dawson midawson@redhat.com