Skip to content

perf_hooks: fix performance timeline wpt failures - #39532

Closed
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:perf_hooks/wpt
Closed

perf_hooks: fix performance timeline wpt failures#39532
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:perf_hooks/wpt

Conversation

@legendecas

Copy link
Copy Markdown
Member

The WPT test runner is unexpectedly running with user-timing tests instead of performance-timeline.

@legendecaslegendecas added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Jul 26, 2021
@legendecas
legendecas marked this pull request as draft July 26, 2021 15:46
@legendecas
legendecas marked this pull request as ready for review July 26, 2021 15:55
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 27, 2021
@nodejs-github-bot

nodejs-github-bot commented Jul 27, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39298/

  • not ok 3099 report/test-report-fatal-error

@nodejs-github-bot

nodejs-github-bot commented Jul 28, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39304/

  • not ok 1480 parallel/test-https-set-timeout-server

@nodejs-github-bot

nodejs-github-bot commented Jul 29, 2021

Copy link
Copy Markdown
Collaborator

@legendecaslegendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 30, 2021
jasnell pushed a commit that referenced this pull request Jul 30, 2021
PR-URL: #39532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@jasnell

Copy link
Copy Markdown
Member

Landed in a27d245

@jasnelljasnell closed this Jul 30, 2021
@legendecas
legendecas deleted the perf_hooks/wpt branch July 30, 2021 14:55
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
PR-URL: #39532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.perf_hooksIssues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@legendecas@nodejs-github-bot@jasnell@XadillaX@targos