Uh oh!
There was an error while loading. Please reload this page.
Diagnostic message for retried tests - #3960
Conversation
Trott
commented
Nov 21, 2015
indutny
commented
Nov 21, 2015
Fantastic! LGTM |
Trott
commented
Nov 22, 2015
TL;DR: Ran a few tests to make sure it works as advertised on SmartOS with ECONNREFUSED errors and it looks good. I doctored up a test that would always fail with ECONNREFUSED and ran it through CI. Here's what it looks like: See https://ci.nodejs.org/job/node-test-commit-smartos/404/nodes=smartos14-64/console for the full console log. Then I made it so it would fail with ECONNREFUSED the first time it ran but succeed the second time it ran. Here's what that looks like: For the full console log on that one: https://ci.nodejs.org/job/node-test-commit-smartos/406/nodes=smartos14-64/console |
indutny
commented
Nov 22, 2015
Still LGTM ;) |
326fce3 to
f9501f6CompareTrott
commented
Nov 24, 2015
One last post-rebase CI: https://ci.nodejs.org/job/node-test-commit/1233/ |
Tests on SmartOS are sometimes retried due to a SmartOS issue on CI. When this happens, a TAP diagnostic message is written. PR-URL: nodejs#3960 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Trott
commented
Nov 24, 2015
CI failures on arm-fanned and smartos but they both look Jenkins-related and not actual test failures. /cc @nodejs/build Failures on windows-fanned look unrelated too. I'll confirm previous failures for those two tests and get them added to the flaky test list. :-/ |
Trott
commented
Nov 24, 2015
Landed in 41519fd |
Tests on SmartOS are sometimes retried due to a SmartOS issue on CI. When this happens, a TAP diagnostic message is written. PR-URL: #3960 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Tests on SmartOS are sometimes retried due to a SmartOS issue on CI. When this happens, a TAP diagnostic message is written. PR-URL: #3960 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Tests on SmartOS are sometimes retried due to a SmartOS issue on CI. When this happens, a TAP diagnostic message is written. PR-URL: #3960 Reviewed-By: Fedor Indutny <fedor@indutny.com>
This is dependent on #3941 being landed first.
Tests on SmartOS are sometimes retried due to a SmartOS issue on CI.
When this happens, a TAP diagnostic message is written.
R=@indutny