Skip to content

[v12.x] http2: update handling of streams on rst_stream frames - #39659

Closed
kumarak wants to merge 2 commits into
nodejs:v12.x-stagingfrom
kumarak:kumarak/v12.x_backport_rst_stream
Closed

[v12.x] http2: update handling of streams on rst_stream frames#39659
kumarak wants to merge 2 commits into
nodejs:v12.x-stagingfrom
kumarak:kumarak/v12.x_backport_rst_stream

Conversation

@kumarak

Copy link
Copy Markdown
Contributor

Backport ref PR #39622 and resolve merge conflict with
git cherry-pick

@github-actionsgithub-actionsBot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. v12.x labels Aug 4, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlau

Copy link
Copy Markdown
Member

Should I expect the testcase to fail on earlier versions of Node.js 12? When I test locally with 12.22.4 and without the http2 change in this PR the testcase passes.

@kumarak

Copy link
Copy Markdown
ContributorAuthor

@richardlau, Ideally the test should verify the fixes but I was unable to reproduce the issue without grpc-js. The original issue scripts are here(repro-node-crash). I tried reproducing it with http2 streams.

So I simplified the test case and only checks the RST_STREAM frames getting sent with cancel error code, the stream is in the paused-reading state, and there is no issue with handling it(e.g: no endpoint hang, no stream close error). The behavior is same what it was previously and the test case passes with the older version as well.

@richardlau

Copy link
Copy Markdown
Member

This went out in 12.22.5 in f2f7a45...9cd1f53.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.http2Issues or PRs related to the http2 subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kumarak@nodejs-github-bot@richardlau@BethGriggs