Uh oh!
There was an error while loading. Please reload this page.
tools: de-rollup-ify lint-md - #39760
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Trottforce-pushed
the
de-rollup
branch
2 times, most recently
from
August 13, 2021 18:24
f763a4c to
bc25f74Compareaduh95
commented
Aug 16, 2021
Contributor
The number of file change and the diff size makes me hesitant to approve that. Maybe you could give more context on why you think Rollup is no longer the correct tool for our use case, and if you think it's worth someone's time to investigate further the issue. |
Trottforce-pushed
the
de-rollup
branch
4 times, most recently
from
August 22, 2021 04:46
9339363 to
3c1c0c5CompareThe rollup stuff stopped working with the massive remark ecosystem move to ESM. Rather than try to troubleshoot, simplify things by removing rollup. It's a great tool for a lot of uses, but less may be more here. This does mean checking in a `node_modules` directory so that the linter runs out-of-the-box, like we do for ESLint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rollup stuff stopped working with the massive remark ecosystem move
to ESM. Rather than try to troubleshoot, simplify things by removing
rollup. It's a great tool for a lot of uses, but less may be more here.
This does mean checking in a
node_modulesdirectory so that the linterruns out-of-the-box, like we do for ESLint.