Skip to content

doc: Replace sane with reasonable - #3980

Closed
lewiscowper wants to merge 1 commit into
nodejs:masterfrom
lewiscowper:language-tweak
Closed

doc: Replace sane with reasonable#3980
lewiscowper wants to merge 1 commit into
nodejs:masterfrom
lewiscowper:language-tweak

Conversation

@lewiscowper

Copy link
Copy Markdown
Contributor

I noticed this slip when reading about modules, and thought I'd pop a PR in.

@ChALkeRChALkeR added the doc Issues and PRs related to the documentations. label Nov 23, 2015
@ChALkeR

Copy link
Copy Markdown
Member

The correct prefix for the commit title would be «doc: », not «docs: ».

@mscdexmscdex added the module Issues and PRs related to the module subsystem. label Nov 23, 2015
@evanlucas

Copy link
Copy Markdown
Contributor

LGTM with what @ChALkeR said

@targos

Copy link
Copy Markdown
Member

LGTM

Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.
@lewiscowper

Copy link
Copy Markdown
ContributorAuthor

Pushed new prefix now.

@lewiscowperlewiscowper changed the title docs: Replace sane with reasonabledoc: Replace sane with reasonableNov 23, 2015
@cjihrig

Copy link
Copy Markdown
Contributor

LGTM

targos pushed a commit to targos/node that referenced this pull request Nov 23, 2015
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.
PR-URL: nodejs#3980
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos

Copy link
Copy Markdown
Member

landed in 3becac2

@targostargos closed this Nov 23, 2015
MylesBorins pushed a commit that referenced this pull request Dec 1, 2015
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.
PR-URL: #3980
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Dec 4, 2015
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.
PR-URL: #3980
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Dec 5, 2015
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.
PR-URL: #3980
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnelljasnell mentioned this pull request Dec 17, 2015
jasnell pushed a commit that referenced this pull request Dec 17, 2015
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.
PR-URL: #3980
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit that referenced this pull request Dec 23, 2015
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.
PR-URL: #3980
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.moduleIssues and PRs related to the module subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@lewiscowper@ChALkeR@evanlucas@targos@cjihrig@mscdex@jasnell@MylesBorins