Uh oh!
There was an error while loading. Please reload this page.
tools: update linter dependencies and move to ESM - #39801
Merged
Conversation
Trott
approved these changes
Aug 18, 2021
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM if lint-md GitHub CI is green once this is pulled out of draft mode.
aduh95
marked this pull request as ready for review
August 20, 2021 04:56
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Aug 20, 2021
nodejs-github-bot
commented
Aug 21, 2021
Collaborator
Trott
commented
Aug 21, 2021
Member
LGTM although like with current master, it doesn't seem to be flagging errors. 😱 |
Trott
commented
Aug 21, 2021
Member
This will hopefully be fixed when we move to remark-preset-lint-node@3.0.1. I've got a PR ready for that, but this should land first, so I'm going to land this now. |
PR-URL: nodejs#39801 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Aug 21, 2021
Member
Landed in af45be7 |
targos pushed a commit
that referenced
this pull request
Aug 22, 2021
PR-URL: #39801 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 4, 2021
PR-URL: #39801 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit id from #39797 which should land first.