Skip to content

tools: update gyp-next to v0.9.5 - #39818

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:bump_gyp
Closed

tools: update gyp-next to v0.9.5#39818
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:bump_gyp

Conversation

@gengjiawen

@gengjiawengengjiawen commented Aug 20, 2021

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. dont-land-on-v12.x gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Aug 20, 2021
@gengjiawengengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2021
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39607/

jasnell
jasnell approved these changes Aug 20, 2021
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@targostargos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 21, 2021
@gengjiawengengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2021
@github-actions

github-actionsBot commented Aug 23, 2021

Copy link
Copy Markdown
Contributor

Landed in 0073831...28113ed

nodejs-github-bot pushed a commit that referenced this pull request Aug 23, 2021
@gengjiawen@nodejs-github-bot
tools: update gyp-next to v0.9.5
28113ed
PR-URL: #39818
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gengjiawen
gengjiawen deleted the bump_gyp branch August 23, 2021 07:48
targos pushed a commit that referenced this pull request Aug 23, 2021
@gengjiawen@targos
tools: update gyp-next to v0.9.5
d82ee96
PR-URL: #39818
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targostargos mentioned this pull request Aug 25, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.gypIssues and PRs related to the GYP tool and .gyp build filesneeds-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gengjiawen@nodejs-github-bot@jasnell@targos@cjihrig