Skip to content

[v16.x backport] stream: add isDisturbed helper - #39819

Closed
ronag wants to merge 2 commits into
nodejs:v16.x-stagingfrom
nxtedition:backport-39628-to-v16.x
Closed

[v16.x backport] stream: add isDisturbed helper#39819
ronag wants to merge 2 commits into
nodejs:v16.x-stagingfrom
nxtedition:backport-39628-to-v16.x

Conversation

@ronag

@ronagronag commented Aug 20, 2021

Copy link
Copy Markdown
Member

No description provided.

@ronagronag changed the title Backport 39628 to v16.x[v16.x backport] stream: add isDisturbed helperAug 20, 2021
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 20, 2021
@ronag
ronag changed the base branch from master to v16.x-stagingAugust 20, 2021 13:30
@ronag
ronagforce-pushed the backport-39628-to-v16.x branch from ef6ccc1 to 574bec6CompareAugust 20, 2021 13:31
@ronagronag mentioned this pull request Aug 20, 2021
Closed
@ronag
stream: add isDisturbed helper
cd6f6c8
Adds a helper util used to determine whether a stream has been
disturbed (read or cancelled).
Refs: nodejs#39627
PR-URL: nodejs#39628
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Backport-PR-URL: nodejs#39819
@ronag
ronagforce-pushed the backport-39628-to-v16.x branch from 574bec6 to cd6f6c8CompareAugust 20, 2021 13:38
@ronag
ronag requested a review from jasnellAugust 20, 2021 14:00
@ronag

ronag commented Aug 20, 2021

Copy link
Copy Markdown
MemberAuthor

@nodejs/streams

@ronagronag added stream Issues and PRs related to the stream subsystem. web streams labels Aug 20, 2021
mcollina
mcollina approved these changes Aug 20, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

targos
targos reviewed Aug 22, 2021
View reviewed changes
Comment threadlib/internal/streams/utils.js
@ronag@targos
Update lib/internal/streams/utils.js
fca6388
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2021
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39634/

@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39641/

@targos

targos commented Aug 23, 2021

Copy link
Copy Markdown
Member

I think this one will be easier to do after #39563 ?

@ronag

ronag commented Aug 23, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I think this one will be easier to do after #39563 ?

Why? I don't think they are related? I think this can land now?

@ronag

ronag commented Aug 23, 2021

Copy link
Copy Markdown
MemberAuthor

CI linting error on markdown which I can't figure out. 😕

@targos

targos commented Aug 23, 2021

Copy link
Copy Markdown
Member

I think this one will be easier to do after #39563 ?

Why? I don't think they are related? I think this can land now?

You're right. I'm mixing things

@targos

targos commented Aug 23, 2021

Copy link
Copy Markdown
Member

CI linting error on markdown which I can't figure out. 😕

It was because 0073831 was missing from v16.x-staging. It's there now.

targos pushed a commit that referenced this pull request Aug 23, 2021
@ronag@targos
stream: add isDisturbed helper
af7047a
Adds a helper util used to determine whether a stream has been
disturbed (read or cancelled).
Refs: #39627
PR-URL: #39628
Backport-PR-URL: #39819
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos

targos commented Aug 23, 2021

Copy link
Copy Markdown
Member

Landed in af7047a

@targostargos closed this Aug 23, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos left review comments
@mcollinamcollinamcollina approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@jasnelljasnellAwaiting requested review from jasnell

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.streamIssues and PRs related to the stream subsystem.toolsIssues and PRs related to the tools directory.web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronag@nodejs-github-bot@targos@mcollina@benjamingr