Skip to content

[v16.x backport] stream: duplexify - #39820

Closed
ronag wants to merge 3 commits into
nodejs:v16.x-stagingfrom
nxtedition:backport-39519-to-v16.x
Closed

[v16.x backport] stream: duplexify#39820
ronag wants to merge 3 commits into
nodejs:v16.x-stagingfrom
nxtedition:backport-39519-to-v16.x

Conversation

@ronag

@ronagronag commented Aug 20, 2021

Copy link
Copy Markdown
Member

PR-URL: #39519
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Aug 20, 2021
@ronag
ronagforce-pushed the backport-39519-to-v16.x branch from defc2b4 to 2eb474eCompareAugust 20, 2021 13:46
@ronagronag changed the title stream: duplexify[v16.x backport] stream: duplexifyAug 20, 2021
@ronag
ronag requested a review from mcollinaAugust 20, 2021 13:59
@ronagronag added the stream Issues and PRs related to the stream subsystem. label Aug 20, 2021
mcollina
mcollina approved these changes Aug 20, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag

ronag commented Aug 20, 2021

Copy link
Copy Markdown
MemberAuthor

@nodejs/streams

@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2021
@ronagronag mentioned this pull request Aug 23, 2021
Closed
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2021
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39642/

@targos

targos commented Aug 23, 2021

Copy link
Copy Markdown
Member

Looks like it conflicts with af7047a

@ronag
stream: duplexify
ea09812
PR-URL: nodejs#39519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <ckbenjamingr@gmail.com>
Backport-PR-URL: nodejs#39820
@ronag
fixup
9506bc2
@ronag
fixup
6d303ea
@ronag
ronagforce-pushed the backport-39519-to-v16.x branch from e20a91c to 6d303eaCompareAugust 23, 2021 12:24
@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2021
@ronag

ronag commented Aug 23, 2021

Copy link
Copy Markdown
MemberAuthor

resolved conflicts

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2021
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39643/

targos pushed a commit that referenced this pull request Aug 23, 2021
@ronag@targos
stream: duplexify
a6d50a1
PR-URL: #39519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <ckbenjamingr@gmail.com>
Backport-PR-URL: #39820
@targos

targos commented Aug 23, 2021

Copy link
Copy Markdown
Member

Thanks. Landed in a6d50a1

@targostargos closed this Aug 23, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

Assignees

No one assigned

Labels

lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ronag@nodejs-github-bot@targos@mcollina