Skip to content

tools: use find-inactive-collaborators to edit README and open pull request - #39825

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:update-process
Closed

tools: use find-inactive-collaborators to edit README and open pull request#39825
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:update-process

Conversation

@Trott

@TrottTrott commented Aug 21, 2021

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 21, 2021
@Trott

Trott commented Aug 21, 2021

Copy link
Copy Markdown
MemberAuthor

I ran this on my fork so I could see what the pull request would look like. https://github.com/Trott/io.js/pull/4/files

aduh95
aduh95 approved these changes Aug 21, 2021
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking suggestion: I haven't tested it, but could we use an async generator here instead?

Comment threadtools/find-inactive-collaborators.mjs
Comment threadtools/find-inactive-collaborators.mjs
Comment threadtools/find-inactive-collaborators.mjs
Comment threadtools/find-inactive-collaborators.mjs
Comment threadtools/find-inactive-collaborators.mjs
Comment threadtools/find-inactive-collaborators.mjs
Comment threadtools/find-inactive-collaborators.mjs
Comment threadtools/find-inactive-collaborators.mjs
Comment threadtools/find-inactive-collaborators.mjs
Comment threadtools/find-inactive-collaborators.mjs
@Trott
tools: use find-inactive-collaborators to modify README.md
972116d
Update find-inactive-collaborators to move inactive collaborators to the
emeriti section of README.md.
@Trott
tools: update workflow to open a pull request
4aea3c9
Now that find-inactive-collaborators.mjs automates the README.md changes
to move the inactive collaborators to the emeriti section, update the
GitHub Actions workflow to open a pull request.
@Trott

Trott commented Aug 24, 2021

Copy link
Copy Markdown
MemberAuthor

Non-blocking suggestion: I haven't tested it, but could we use an async generator here instead?

Thanks for the suggestion. I think it's more clear/obvious when reading the code if we use the synchronous function so I'm inclined to leave it as is, or at least save the suggested change for a subsequent pull request where just it can be discussed. Since you labeled the suggestion non-blocking, I'm going to mark it as resolved. Hope that's OK.

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2021
@github-actions

github-actionsBot commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

Landed in 0d88c14...cee024a

nodejs-github-bot pushed a commit that referenced this pull request Aug 25, 2021
@Trott@nodejs-github-bot
tools: use find-inactive-collaborators to modify README.md
67f96dd
Update find-inactive-collaborators to move inactive collaborators to the
emeriti section of README.md.
PR-URL: #39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Aug 25, 2021
@Trott@nodejs-github-bot
tools: update workflow to open a pull request
cee024a
Now that find-inactive-collaborators.mjs automates the README.md changes
to move the inactive collaborators to the emeriti section, update the
GitHub Actions workflow to open a pull request.
PR-URL: #39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Aug 25, 2021
@Trott@targos
tools: use find-inactive-collaborators to modify README.md
d33f897
Update find-inactive-collaborators to move inactive collaborators to the
emeriti section of README.md.
PR-URL: #39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Aug 25, 2021
@Trott@targos
tools: update workflow to open a pull request
f98311a
Now that find-inactive-collaborators.mjs automates the README.md changes
to move the inactive collaborators to the emeriti section, update the
GitHub Actions workflow to open a pull request.
PR-URL: #39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Aug 25, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott@targos
tools: use find-inactive-collaborators to modify README.md
417a3ac
Update find-inactive-collaborators to move inactive collaborators to the
emeriti section of README.md.
PR-URL: #39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott@targos
tools: update workflow to open a pull request
55493f2
Now that find-inactive-collaborators.mjs automates the README.md changes
to move the inactive collaborators to the emeriti section, update the
GitHub Actions workflow to open a pull request.
PR-URL: #39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Sep 4, 2021
Merged
@Trott
Trott deleted the update-process branch September 25, 2022 17:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@jasnell@aduh95@nodejs-github-bot