tools: fix markdown linting by Trott · Pull Request #39832 · nodejs/node

Trott · 2021-08-21T14:13:10Z

This updates remark-preset-lint-node to 3.0.1, which actually works
unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually
linting!)

It also updates rollup and the rollup config. So this uses the
latest everything as of this writing.

This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing.

Trott · 2021-08-21T14:13:24Z

@nodejs/linting

github-actions · 2021-08-21T14:18:04Z

Fast-track has been requested by @Trott. Please 👍 to approve.

targos · 2021-08-21T14:22:33Z

Error: Cannot find module 'node:process'

require('node:...') isn't supported yet in v14.x (should be there in the next minor release)

aduh95 · 2021-08-21T15:31:51Z

Error: Cannot find module 'node:process'
require('node:...') isn't supported yet in v14.x (should be there in the next minor release)

I suppose we need to either make Rollup output ESM (lint-md.mjs), or make the lint-md and lint-md GHA jobs run on v16.x.

Trott · 2021-08-21T15:45:11Z

Error: Cannot find module 'node:process'
require('node:...') isn't supported yet in v14.x (should be there in the next minor release)
I suppose we need to either make Rollup output ESM (lint-md.mjs), or make the lint-md and lint-md GHA jobs run on v16.x.

I made it ESM. PTAL

Trott · 2021-08-21T15:47:36Z

(By the way, my reason for the fast-track request is that right now, the linter isn't doing anything, so errors may be landing in doc changes. Right now, there are no lint errors. I'd like to get this landed ASAP to minimize the possibility of errors appearing between now and when this lands.)

targos

tools/lint-md.js is referenced in:

.eslintignore
vcbuild.bat

Trott · 2021-08-21T16:07:04Z

tools/lint-md.js is referenced in:
.eslintignore
vcbuild.bat

Whoops, forgot to grep.

OK, fixed.

github-actions · 2021-08-21T20:58:18Z

Commit Queue failed

- Loading data for nodejs/node/pull/39832
✔ Done loading data for nodejs/node/pull/39832
----------------------------------- PR info ------------------------------------
Title tools: fix markdown linting (#39832)
Author Rich Trott (@Trott)
Branch Trott:lint-preset-update -> nodejs:master
Labels tools, fast-track
Commits 4
- tools: fix markdown linting
- fixup! tools: fix markdown linting
- fixup! fixup! tools: fix markdown linting
- fixup! fixup! fixup! tools: fix markdown linting
Committers 1
- Rich Trott PR-URL: https://github.com/nodejs/node/pull/39832
Reviewed-By: Daijiro Wachi Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/39832
Reviewed-By: Daijiro Wachi Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel --------------------------------------------------------------------------------
ℹ This PR was created on Sat, 21 Aug 2021 14:13:10 GMT
✔ Approvals: 3
✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/39832#pullrequestreview-735498792
✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/39832#pullrequestreview-735505690
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/39832#pullrequestreview-735505770
ℹ This PR is being fast-tracked
✔ Last GitHub Actions successful
✖ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/1154347243

nodejs-github-bot · 2021-08-22T03:42:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/39628/

github-actions · 2021-08-22T04:13:35Z

Landed in 1deafcd...1110947

This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing. PR-URL: #39832 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

tools: fix markdown linting
02f7e96
This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing.

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 21, 2021

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 21, 2021

watilde approved these changes Aug 21, 2021
View reviewed changes

targos approved these changes Aug 21, 2021
View reviewed changes

targos reviewed Aug 21, 2021
View reviewed changes

Comment threadtools/node-lint-md-cli-rollup/rollup.config.js Outdated

Trott added 2 commits August 21, 2021 08:37

fixup! tools: fix markdown linting
09213f3

fixup! fixup! tools: fix markdown linting
09d820e

targos requested changes Aug 21, 2021
View reviewed changes

fixup! fixup! fixup! tools: fix markdown linting
c6f73a9

targos approved these changes Aug 21, 2021
View reviewed changes

aduh95 approved these changes Aug 21, 2021
View reviewed changes

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2021

github-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2021

github-actionsBot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 21, 2021

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2021

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2021

This comment has been minimized.
Sign in to view

Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 22, 2021

github-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2021

github-actionsBot closed this Aug 22, 2021

targos mentioned this pull request Aug 25, 2021
v16.8.0 release proposal #39875
Merged

targos mentioned this pull request Sep 4, 2021
v14.18.0 release proposal #39990
Merged

Trott deleted the lint-preset-update branch September 25, 2022 17:10

Uh oh!

Uh oh!

Conversation

Trott commented Aug 21, 2021

Uh oh!

Trott commented Aug 21, 2021

Uh oh!

github-actionsBot commented Aug 21, 2021

Uh oh!

targos commented Aug 21, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

aduh95 commented Aug 21, 2021

Uh oh!

Trott commented Aug 21, 2021

Uh oh!

Trott commented Aug 21, 2021

Uh oh!

targos left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Aug 21, 2021

Uh oh!

github-actionsBot commented Aug 21, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Aug 22, 2021

Uh oh!

github-actionsBot commented Aug 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

targos commented Aug 21, 2021•
edited
Loading