Skip to content

doc: move util.toUSVString() outside of deprecated group - #39840

Closed
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:move/tousvstring-documentation
Closed

doc: move util.toUSVString() outside of deprecated group#39840
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:move/tousvstring-documentation

Conversation

@lpinca

@lpincalpinca commented Aug 22, 2021

Copy link
Copy Markdown
Member

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Aug 22, 2021
@lpincalpinca mentioned this pull request Aug 22, 2021
@lpinca
lpincaforce-pushed the move/tousvstring-documentation branch from e82c393 to 6737257CompareAugust 22, 2021 06:06
@targostargos added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 22, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Landed in 82ae00c...0073831

nodejs-github-bot pushed a commit that referenced this pull request Aug 22, 2021
Refs: https://github.com/nodejs/node/pull/39814/files#r693445849
PR-URL: #39840
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@lpinca
lpinca deleted the move/tousvstring-documentation branch August 22, 2021 10:51
@Trott

Copy link
Copy Markdown
Member

This also happened to fix a markdown lint error that snuck in while the linter was broken. 👍

targos pushed a commit that referenced this pull request Aug 23, 2021
Refs: https://github.com/nodejs/node/pull/39814/files#r693445849
PR-URL: #39840
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targostargos mentioned this pull request Aug 25, 2021
targos pushed a commit that referenced this pull request Sep 4, 2021
Refs: https://github.com/nodejs/node/pull/39814/files#r693445849
PR-URL: #39840
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targostargos mentioned this pull request Sep 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.utilIssues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@lpinca@Trott@targos@ZYSzys@RaisinTen@nodejs-github-bot