Skip to content

crypto: use validateObject - #39872

Closed
VoltrexKeyva wants to merge 1 commit into
nodejs:masterfrom
VoltrexKeyva:patch-11
Closed

crypto: use validateObject#39872
VoltrexKeyva wants to merge 1 commit into
nodejs:masterfrom
VoltrexKeyva:patch-11

Conversation

@VoltrexKeyva

Copy link
Copy Markdown
Contributor

The validateObject() validator can be used to cleanup validation and
keep consistency.

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Aug 24, 2021
Comment threadlib/internal/crypto/keys.js Outdated
The `validateObject()` validator can be used to cleanup validation and
keep consistency.
@LxxyxLxxyx added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@VoltrexKeyvaVoltrexKeyva removed the needs-ci PRs that need a full CI run. label Aug 30, 2021
@LxxyxLxxyx added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 31, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 31, 2021
@VoltrexKeyvaVoltrexKeyva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 3, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@Ayase-252Ayase-252 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 17, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 17, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Landed in 8a92018...55379eb

nodejs-github-bot pushed a commit that referenced this pull request Sep 17, 2021
The `validateObject()` validator can be used to cleanup validation and
keep consistency.
PR-URL: #39872
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
@VoltrexKeyva
VoltrexKeyva deleted the patch-11 branch September 17, 2021 11:13
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
The `validateObject()` validator can be used to cleanup validation and
keep consistency.
PR-URL: #39872
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
The `validateObject()` validator can be used to cleanup validation and
keep consistency.
PR-URL: #39872
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Sep 21, 2021
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@VoltrexKeyva@nodejs-github-bot@jasnell@XadillaX@Lxxyx@Mesteery@Ayase-252